Address CodeRabbit feedback: improve script robustness and formatting

- Replace 'which' with POSIX-compliant 'command -v' in test scripts
- Fix markdown formatting issues in DEVELOPMENT.md (add blank lines)
- Separate variable declaration and assignment in test_nvim_detection.sh
- Add robust absolute path resolution using readlink and BASH_SOURCE
- Enhance error handling with 'set -euo pipefail' for strict mode
- Replace unreliable $0 references in bash -c contexts

These changes improve portability, reliability, and follow shell scripting
best practices while addressing all linting and formatting issues.

Author: krishna-bala

DEVELOPMENT.md

@@ -188,11 +188,13 @@ make test-config
 When running tests from within a Neovim instance (such as when using Claude Code via claude-code.nvim), the test script automatically handles the `$NVIM` environment variable which normally points to a socket file instead of the nvim executable.
 
 The test script will:
+
 - Use the `$NVIM` variable if it points to a valid executable file
 - Fall back to finding `nvim` in `$PATH` if `$NVIM` points to a socket or invalid path
 - Display which nvim binary is being used for transparency
 
 To verify the NVIM detection logic works correctly, you can run:
+
 ```bash
 ./scripts/test_nvim_detection.sh
 ```

scripts/test.sh

@@ -18,8 +18,7 @@ if [ -n "$NVIM" ] && [ -x "$NVIM" ] && [ ! -S "$NVIM" ]; then
   echo "Using NVIM from environment: $NVIM"
 else
   # Find nvim in PATH
-  NVIM=$(which nvim)
-  if [ -z "$NVIM" ]; then
+  if ! NVIM=$(command -v nvim); then
     echo "Error: nvim not found in PATH"
     exit 1
   fi

scripts/test_nvim_detection.sh

@@ -1,9 +1,13 @@
 #!/bin/bash
-set -e
+set -euo pipefail
 
 # Test script to verify NVIM environment variable detection logic
 # This script tests the fix for handling NVIM variable when running inside Neovim
 
+# Get the absolute directory path of this script
+SCRIPT_DIR="$(cd "$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")" && pwd)"
+PROJECT_DIR="$(dirname "$SCRIPT_DIR")"
+
 echo "Testing NVIM environment variable detection..."
 
 # Save original NVIM value
@@ -13,7 +17,7 @@ ORIGINAL_NVIM="$NVIM"
 echo "Test 1: NVIM points to a socket"
 export NVIM="/tmp/test_socket"
 mkfifo "$NVIM" 2>/dev/null || true  # Create a named pipe (similar to socket)
-if timeout 5 bash -c 'cd "$(dirname "$0")" && ./scripts/test.sh' 2>&1 | head -10 | grep -q "Running tests with.*nvim"; then
+if timeout 5 bash -c "cd '$PROJECT_DIR' && ./scripts/test.sh" 2>&1 | head -10 | grep -q "Running tests with.*nvim"; then
     echo "✓ Fallback to PATH works"
 else
     echo "✗ Fallback failed"
@@ -22,8 +26,12 @@ rm -f "$NVIM"
 
 # Test 2: NVIM points to valid executable
 echo "Test 2: NVIM points to valid executable"
-export NVIM="$(which nvim)"
-if timeout 5 bash -c 'cd "$(dirname "$0")" && ./scripts/test.sh' 2>&1 | head -10 | grep -q "Using NVIM from environment"; then
+if ! NVIM=$(command -v nvim); then
+  echo "Error: nvim not found in PATH"
+  exit 1
+fi
+export NVIM
+if timeout 5 bash -c "cd '$PROJECT_DIR' && ./scripts/test.sh" 2>&1 | head -10 | grep -q "Using NVIM from environment"; then
     echo "✓ Using provided NVIM works"
 else
     echo "✗ Using provided NVIM failed"
@@ -32,7 +40,7 @@ fi
 # Test 3: NVIM points to non-existent path
 echo "Test 3: NVIM points to non-existent path"
 export NVIM="/nonexistent/nvim"
-if timeout 5 bash -c 'cd "$(dirname "$0")" && ./scripts/test.sh' 2>&1 | head -10 | grep -q "Running tests with.*nvim"; then
+if timeout 5 bash -c "cd '$PROJECT_DIR' && ./scripts/test.sh" 2>&1 | head -10 | grep -q "Running tests with.*nvim"; then
     echo "✓ Fallback from invalid path works"
 else
     echo "✗ Fallback from invalid path failed"
@@ -41,7 +49,7 @@ fi
 # Test 4: NVIM is unset
 echo "Test 4: NVIM is unset"
 unset NVIM
-if timeout 5 bash -c 'cd "$(dirname "$0")" && ./scripts/test.sh' 2>&1 | head -10 | grep -q "Running tests with.*nvim"; then
+if timeout 5 bash -c "cd '$PROJECT_DIR' && ./scripts/test.sh" 2>&1 | head -10 | grep -q "Running tests with.*nvim"; then
     echo "✓ Unset NVIM works"
 else
     echo "✗ Unset NVIM failed"