responding to AI PR feedback

Author: Tim Huff

src/groundlight/edge/config.py

@@ -84,6 +84,24 @@ class DetectorsConfig(BaseModel):
 
     @model_validator(mode="after")
     def validate_inference_configs(self):
+        for name, config in self.edge_inference_configs.items():
+            if name != config.name:
+                raise ValueError(
+                    f"Edge inference config key '{name}' must match InferenceConfig.name '{config.name}'."
+                )
+
+        seen_detector_ids = set()
+        duplicate_detector_ids = set()
+        for detector_config in self.detectors:
+            detector_id = detector_config.detector_id
+            if detector_id in seen_detector_ids:
+                duplicate_detector_ids.add(detector_id)
+            else:
+                seen_detector_ids.add(detector_id)
+        if duplicate_detector_ids:
+            duplicates = ", ".join(sorted(duplicate_detector_ids))
+            raise ValueError(f"Duplicate detector IDs are not allowed: {duplicates}.")
+
         for detector_config in self.detectors:
             if detector_config.edge_inference_config not in self.edge_inference_configs:
                 raise ValueError(f"Edge inference config '{detector_config.edge_inference_config}' not defined.")

test/unit/test_edge_config.py

@@ -51,6 +51,35 @@ def test_add_detector_rejects_different_named_inference_config():
         )
 
 
+def test_constructor_rejects_duplicate_detector_ids():
+    with pytest.raises(ValueError, match="Duplicate detector IDs"):
+        DetectorsConfig(
+            edge_inference_configs={"default": DEFAULT},
+            detectors=[
+                {"detector_id": "det_1", "edge_inference_config": "default"},
+                {"detector_id": "det_1", "edge_inference_config": "default"},
+            ],
+        )
+
+
+def test_constructor_rejects_mismatched_inference_config_key_and_name():
+    with pytest.raises(ValueError, match="must match InferenceConfig.name"):
+        DetectorsConfig(
+            edge_inference_configs={"default": InferenceConfig(name="not_default")},
+            detectors=[],
+        )
+
+
+def test_constructor_accepts_matching_inference_config_key_and_name():
+    config = DetectorsConfig(
+        edge_inference_configs={"default": InferenceConfig(name="default")},
+        detectors=[{"detector_id": "det_1", "edge_inference_config": "default"}],
+    )
+
+    assert list(config.edge_inference_configs.keys()) == ["default"]
+    assert [detector.detector_id for detector in config.detectors] == ["det_1"]
+
+
 def test_edge_endpoint_config_add_detector_delegates_to_detectors_logic():
     config = EdgeEndpointConfig()
     config.add_detector("det_1", NO_CLOUD)