refactor: add debug logging support and constants

Author: gsdevme

internal/app/gitops-commit/cmd/root.go

@@ -1,6 +1,10 @@
 package cmd
 
-import "github.com/spf13/cobra"
+import (
+	"github.com/google/martian/log"
+	"github.com/spf13/cobra"
+	"os"
+)
 
 func NewRootCommand() *cobra.Command {
 	c := cobra.Command{
@@ -11,6 +15,12 @@ func NewRootCommand() *cobra.Command {
 		},
 	}
 
+	d := os.Getenv("DEBUG")
+
+	if len(d) > 0 {
+		log.SetLevel(log.Debug)
+	}
+
 	c.AddCommand(newRunCommand())
 	c.AddCommand(newServeCommand())
 

internal/app/gitops-commit/cmd/serve.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"fmt"
+	"github.com/google/martian/log"
 	"github.com/gsdevme/gitops-commit/internal/app/gitops-commit/slackhttp"
 	"github.com/gsdevme/gitops-commit/internal/pkg/gitops"
 	"github.com/spf13/cobra"
@@ -40,7 +41,7 @@ func newServeCommand() *cobra.Command {
 				ReadTimeout:  3 * time.Second,
 				WriteTimeout: 5 * time.Second,
 				ConnState: func(conn net.Conn, state http.ConnState) {
-					//fmt.Fprintf(os.Stdout, "%s - %s\n", conn.RemoteAddr(), state.String())
+					log.Debugf("%s - %s\n", conn.RemoteAddr(), state.String())
 				},
 			}
 

internal/app/gitops-commit/slackhttp/handler.go

@@ -3,18 +3,24 @@ package slackhttp
 import (
 	"encoding/json"
 	"fmt"
+	"github.com/google/martian/log"
 	"github.com/gsdevme/gitops-commit/internal/pkg/gitops"
 	"github.com/slack-go/slack"
 	"net/http"
 	"strings"
 )
 
+const (
+	SlackUnknownResponse        = "Incorrect usage, expected /gitops-commit [command] [name] [tag]"
+	SlackUnknownCommandResponse = "Unknown command '%s', expected /gitops-commit [command] [name] [tag]"
+)
+
 func (s *server) handleSlackCommand(registry *NamedRepositoryRegistry) func(http.ResponseWriter, slack.SlashCommand) {
 	return func(w http.ResponseWriter, sl slack.SlashCommand) {
 		text := strings.Split(sl.Text, " ")
 
 		if len(text) < 3 || len(text) > 3 {
-			respondSlack("Incorrect usage, expected /gitops-commit [command] [name] [tag]", slack.ResponseTypeEphemeral, w)
+			respondSlack(SlackUnknownResponse, slack.ResponseTypeEphemeral, w)
 
 			return
 		}
@@ -28,7 +34,7 @@ func (s *server) handleSlackCommand(registry *NamedRepositoryRegistry) func(http
 			return
 		default:
 			respondSlack(
-				fmt.Sprintf("Unknown command %s, expected /gitops-commit [command] [name] [tag]", command),
+				fmt.Sprintf(SlackUnknownCommandResponse, command),
 				slack.ResponseTypeEphemeral,
 				w,
 			)
@@ -73,7 +79,7 @@ func deploy(s *server, w http.ResponseWriter, registry *NamedRepositoryRegistry,
 	go func() {
 		err = gitops.DeployVersionHandler(command)
 		if err != nil {
-			respondSlack(fmt.Sprintf("failed to deploy: %s", err), slack.ResponseTypeEphemeral, w)
+			log.Errorf("failed to deploy %w", err)
 
 			return
 		}
@@ -92,7 +98,6 @@ func respondSlack(m string, t string, w http.ResponseWriter) {
 		ResponseType: t,
 	})
 	if err != nil {
-		fmt.Println(err)
 		w.WriteHeader(http.StatusInternalServerError)
 		return
 	}