Workaround for root menu event and fixes for Enum and string property modals

Author: tznind

src/UI/Editor.cs

@@ -954,25 +954,42 @@ private void CreateAndShowContextMenu(Mouse? m, Design? rightClicked)
             .Except(setProps)
             .GroupBy(k => k.Category, p=>ToMenuItem(app,p));
 
-        var setPropsItems = setProps.Select(p=>ToMenuItem(app,p)).ToArray();
+        var setPropsItems = setProps.Select(p=>ToMenuItem(app,p)).ToList();
         bool hasPropsItems = setPropsItems.Any();
 
         var all = new List<MenuItem>();
 
         // only add the set properties category if there are some
         if (hasPropsItems)
         {
+            // Also add to the submenu an 'All' version
+            // Workaround for https://github.com/gui-cs/Terminal.Gui/issues/4876 
+            // Previously user could do it by selecting the root 'Properties' expandable
+            // menu
+            setPropsItems.Insert(0, new MenuItem() { 
+                Title="(All)",
+                Action = () =>
+                    {
+                        if (selected.Length == 1 || rightClicked != null)
+                        {
+                            this.ShowEditProperties(rightClicked ?? selected[0]);
+                        }
+                    },
+                });
+
             all.Add(new MenuItem()
             {
                 Title = name,
-                Action = () =>
+                SubMenu = new Menu(setPropsItems)
+                /*
+                 * No longer supported, see https://github.com/gui-cs/Terminal.Gui/issues/4876
+                 * ,Action = () =>
                 {
                     if (selected.Length == 1 || rightClicked != null)
                     {
                         this.ShowEditProperties(rightClicked ?? selected[0]);
                     }
-                },
-                SubMenu = new Menu(setPropsItems)
+                },*/
             });
         }
 

src/UI/ValueFactory.cs

@@ -91,8 +91,9 @@ internal static bool GetNewValue(IApplication app, string propertyName, Design d
             }
 
             if (
-                type.IsGenericType(typeof(IEnumerable<>)) ||
-                type.IsAssignableTo(typeof(IList))
+                type != typeof(string) &&
+                (type.IsGenericType(typeof(IEnumerable<>)) ||
+                type.IsAssignableTo(typeof(IList)))
                 )
             {
                 var elementType = type.GetElementTypeEx()
@@ -227,6 +228,7 @@ private static bool IsEnumOrNullableEnum(Type type, object? oldValue, out Enum?
             if(type.IsEnum)
             {
                 enumValue = (Enum?)oldValue;
+                return true;
             }
 
             if(Nullable.GetUnderlyingType(type) is Type underlying && underlying.IsEnum)