TabView has been deleted :(

Author: tznind

Showcase/Showcase.csproj

@@ -9,7 +9,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Terminal.Gui" Version="2.0.0-develop.5217 " />
+    <PackageReference Include="Terminal.Gui" Version="2.0.0-develop.5281 " />
   </ItemGroup>
 
 </Project>

src/Design.cs

@@ -15,7 +15,6 @@
 using TerminalGuiDesigner.Operations.MenuOperations;
 using TerminalGuiDesigner.Operations.StatusBarOperations;
 using TerminalGuiDesigner.Operations.TableViewOperations;
-using TerminalGuiDesigner.Operations.TabOperations;
 using TerminalGuiDesigner.ToCode;
 
 namespace TerminalGuiDesigner;
@@ -42,15 +41,13 @@ public class Design
     private readonly HashSet<Type> excludeTextPropertyFor = new()
     {
         typeof(FrameView),
-        typeof(TabView),
         typeof(Window),
         typeof(GraphView),
         typeof(HexView),
         typeof(Line),
         typeof(ListView),
         typeof(MenuBar),
         typeof(TableView),
-        typeof(TabView),
         typeof(TreeView),
         typeof(Dialog),
         typeof(NumericUpDown),
@@ -356,20 +353,6 @@ public IEnumerable<IOperation> GetExtraOperations(Point pos)
 
         switch ( this.View )
         {
-            case TabView tabView:
-            {
-                yield return new AddTabOperation(App, this, null);
-
-                if (tabView.SelectedTab != null)
-                {
-                    yield return new RemoveTabOperation(App, this, tabView.SelectedTab);
-                    yield return new RenameTabOperation(App, this, tabView.SelectedTab, null);
-                    yield return new MoveTabOperation(App, this, tabView.SelectedTab, -1);
-                    yield return new MoveTabOperation(App, this, tabView.SelectedTab, 1);
-                }
-
-                break;
-            }
             case MenuBar mb:
             {
                 yield return new AddMenuOperation(App, this, null);
@@ -798,15 +781,6 @@ private IEnumerable<Property> LoadDesignableProperties()
             yield return this.CreateSubProperty(nameof(TableStyle.ShowVerticalHeaderLines), nameof(TableView.Style), tv.Style);
         }
 
-        if (this.View is TabView tabView)
-        {
-            yield return this.CreateProperty(nameof(TabView.MaxTabTextWidth));
-
-            yield return this.CreateSubProperty(nameof(TabStyle.ShowBorder), nameof(TabView.Style), tabView.Style);
-            yield return this.CreateSubProperty(nameof(TabStyle.ShowTopLine), nameof(TabView.Style), tabView.Style);
-            yield return this.CreateSubProperty(nameof(TabStyle.TabsOnBottom), nameof(TabView.Style), tabView.Style);
-        }
-
         if (this.View is OptionSelector)
         {
             yield return this.CreateProperty(nameof(OptionSelector.Labels));

src/MenuBarExtensions.cs

@@ -46,7 +46,7 @@ public static class MenuBarExtensions
             return null;
         }
 
-        var clientPoint = menuBar.ScreenToContent(new Point(screenX, 0));
+        var clientPoint = menuBar.ScreenToViewport(new Point(screenX, 0));
 
         // if click is not in our client area
         if (clientPoint.X < initialWhitespace)

src/Operations/AddViewOperation.cs

@@ -143,11 +143,6 @@ private string TypeNameDelegate(Type? t)
 
     private View GetViewToAddTo()
     {
-        if (this.to.View is TabView tabView)
-        {
-            return tabView.SelectedTab.View;
-        }
-
         return this.to.View;
     }
 }

src/Operations/DragOperation.cs

@@ -137,13 +137,6 @@ public View? DropInto
                 return;
             }
 
-            // When dropping onto a TabView
-            if (value is TabView tv && tv.SelectedTab != null && tv.SelectedTab.View != null)
-            {
-                // Add to the content area of the selected tab instead
-                value = tv.SelectedTab.View;
-            }
-
             this.dropInto = value;
 
 

src/Operations/OperationFactory.cs

@@ -109,7 +109,7 @@ private IEnumerable<IOperation> CreateOperations(Mouse? m, Design d)
     {
         var ops = m == null || !m.Position.HasValue?
             d.GetExtraOperations() :
-            d.GetExtraOperations(d.View.ScreenToContent(m.Position.Value));
+            d.GetExtraOperations(d.View.ScreenToViewport(m.Position.Value));
 
         foreach (var extra in ops.Where(c => !c.IsImpossible))
         {

src/Operations/PasteOperation.cs

@@ -160,11 +160,6 @@ private bool Paste(Design copy, Design into)
 
         this.CopyProperties(copy, cloneDesign);
 
-        if (clone is TabView tabView)
-        {
-            this.CloneTabView((TabView)copy.View, tabView);
-        }
-        else
         if (copy.IsContainerView)
         {
             foreach (var content in copy.View.GetActualSubviews())
@@ -225,30 +220,6 @@ private void CloneTableView(TableView copy, TableView pasted)
         pasted.Update();
     }
 
-    private void CloneTabView(TabView copy, TabView pasted)
-    {
-        // clear tabs in the pasted view as they will just come from ViewFactory
-        foreach (var tab in pasted.Tabs.ToArray())
-        {
-            pasted.RemoveTab(tab);
-        }
-
-        // add a new Tab for each one in the source
-        foreach (var copyTab in copy.Tabs)
-        {
-            var tab = pasted.AddEmptyTab(copyTab.DisplayText?.ToString() ?? Operation.Unnamed);
-
-            // copy the tab contents
-            copy.SelectedTab = copyTab;
-            pasted.SelectedTab = tab;
-
-            foreach (var copySub in copyTab.View.GetActualSubviews())
-            {
-                this.Paste(copySub, (Design)pasted.Data);
-            }
-        }
-    }
-
     private void MigratePosRelatives()
     {
         var everyone = this.to.GetAllDesigns().ToArray();