Skip to content

Commit 929a807

Browse files
author
tznind
committed
Fix DefaultMenuBarItems_IsExactlyAsExpected
1 parent 4d25f9d commit 929a807

4 files changed

Lines changed: 14 additions & 15 deletions

File tree

Showcase/Showcase.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</PropertyGroup>
1010

1111
<ItemGroup>
12-
<PackageReference Include="Terminal.Gui" Version="2.0.0-develop.4881 " />
12+
<PackageReference Include="Terminal.Gui" Version="2.0.0-develop.4946 " />
1313
</ItemGroup>
1414

1515
</Project>

src/TerminalGuiDesigner.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<PackageOutputPath>./nupkg</PackageOutputPath>
2121
<ImplicitUsings>enable</ImplicitUsings>
2222
<PackageId>TerminalGuiDesigner</PackageId>
23-
<Version>2.0.0-develop.4881 </Version>
23+
<Version>2.0.0-develop.4946 </Version>
2424
<Authors>Thomas Nind</Authors>
2525
<Nullable>enable</Nullable>
2626
<PackageLicenseExpression>MIT</PackageLicenseExpression>
@@ -33,7 +33,7 @@
3333
<PackageIcon>logo.png</PackageIcon>
3434
<PackageReadmeFile>README.md</PackageReadmeFile>
3535
<PackageReleaseNotes>
36-
2.0.0-alpha.4881
36+
2.0.0-alpha.4946
3737
* Update to latest nuget package
3838
* Fix crash caused moving PosRelative view without its pair into different container View
3939
2.0.0-alpha.4519
@@ -165,7 +165,7 @@
165165
<PackageReference Include="Serilog" Version="4.2.0" />
166166
<PackageReference Include="Serilog.Extensions.Logging" Version="9.0.0" />
167167
<PackageReference Include="Serilog.Sinks.File" Version="6.0.0" />
168-
<PackageReference Include="Terminal.Gui" Version="2.0.0-develop.4881 " />
168+
<PackageReference Include="Terminal.Gui" Version="2.0.0-develop.4946 " />
169169
<PackageReference Include="nlog" Version="5.3.3" />
170170
<PackageReference Include="Basic.Reference.Assemblies.Net100" Version="1.7.7" />
171171
<PackageReference Include="System.CodeDom" Version="10.0.0" />

src/ViewFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ internal static MenuBarItem[] DefaultMenuBarItems
7979
{
8080
return
8181
[
82-
new( "_File (F9)",
82+
new MenuBarItem( "_File (F9)",
8383
[ new MenuItem( DefaultMenuItemText, string.Empty, static ( ) => { } ) ] )
8484
];
8585
}

tests/ViewFactoryTests.cs

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
using System.Reflection;
33
using System.Runtime.CompilerServices;
44
using Terminal.Gui.ViewBase;
5+
using Terminal.Gui.Views;
56

67
namespace UnitTests;
78

@@ -107,17 +108,15 @@ public void CreateT_ThrowsOnUnsupportedTypes( [ValueSource( nameof( CreateT_Thro
107108
[Category( "Change Control" )]
108109
public void DefaultMenuBarItems_IsExactlyAsExpected( )
109110
{
110-
Assert.Multiple( static ( ) =>
111-
{
112-
Assert.That( ViewFactory_DefaultMenuBarItems, Has.Length.EqualTo( 1 ) );
113-
Assert.That( ViewFactory_DefaultMenuBarItems[ 0 ].Title, Is.EqualTo( "_File (F9)" ) );
114-
} );
115111

116-
Assert.Multiple( static ( ) =>
117-
{
118-
Assert.That( ViewFactory_DefaultMenuBarItems[ 0 ].SubViews, Has.Length.EqualTo( 1 ) );
119-
Assert.That( ViewFactory_DefaultMenuBarItems[ 0 ].SubViews.ElementAt( 0 ).Title, Is.EqualTo( ViewFactory.DefaultMenuItemText ) );
120-
} );
112+
// Confirm creates a single menu
113+
Assert.That( ViewFactory_DefaultMenuBarItems.Count, Is.EqualTo(1));
114+
Assert.That( ViewFactory_DefaultMenuBarItems[ 0 ].SubViews.ElementAt(0).Text, Is.EqualTo( "_File (F9)" ) );
115+
116+
// With single item under it "Edit Me"
117+
Assert.That( ViewFactory_DefaultMenuBarItems [ 0 ].PopoverMenu, Is.Not.Null);
118+
Assert.That( ViewFactory_DefaultMenuBarItems[ 0 ].PopoverMenu!.Root!.SubViews.Count, Is.EqualTo( 1 ) );
119+
Assert.That(ViewFactory_DefaultMenuBarItems[0].PopoverMenu!.Root!.SubViews.ElementAt(0).Title, Is.EqualTo("Edit Me"));
121120
}
122121

123122
[Test]

0 commit comments

Comments
 (0)