Change PosEditor to use radio group and text autocomplete

Mark ComboBox as not a supported control
ComboBox has always been buggy, lets just get rid of it till it works.

Author: tznind

src/UI/Windows/PosEditor.Designer.cs

@@ -23,6 +23,7 @@ namespace TerminalGuiDesigner.UI.Windows;
 public partial class PosEditor : Dialog, IValueGetterDialog {
 
     private Design design;
+    private readonly Dictionary<string, Design> _siblings;
 
     /// <summary>
     /// Users configured <see cref="Pos"/> (assembled from radio button
@@ -57,13 +58,18 @@ public PosEditor(Design design, Pos oldValue) {
         Cancelled = true;
         Modal = true;
 
-        var siblings = design.GetSiblings().ToListObs();
+        _siblings = design.GetSiblings().ToDictionary(
+            d=>d.FieldName,
+            d=>d);
 
-        ddRelativeTo.SetSource(siblings);
-        ddSide.SetSource(Enum.GetValues(typeof(Side)).Cast<Enum>().ToListObs());
+        tbRelativeTo.Autocomplete.SuggestionGenerator = new SingleWordSuggestionGenerator()
+        {
+            AllSuggestions = _siblings.Keys.OrderBy(a => a).ToList()
+        };
 
         var val = oldValue;
-        if(val.GetPosType(siblings,out var type,out var value,out var relativeTo,out var side, out var offset))
+        if(val.GetPosType(_siblings.Values.ToList(),
+               out var type,out var value,out var relativeTo,out var side, out var offset))
         {
             switch(type)
             {
@@ -76,8 +82,8 @@ public PosEditor(Design design, Pos oldValue) {
                 case PosType.Relative:
                     rgPosType.SelectedItem = 2;
                     if(relativeTo != null)
-                        ddRelativeTo.SelectedItem = siblings.IndexOf(relativeTo);
-                    ddSide.SelectedItem = (int)side;
+                        tbRelativeTo.Text = relativeTo.FieldName;
+                    rgSide.SelectedItem = (int)side;
                     break;
                 case PosType.Center:
                     rgPosType.SelectedItem = 3;                        
@@ -120,9 +126,9 @@ private void SetupForCurrentPosType()
         {
             case PosType.Percent:
                 lblRelativeTo.Visible = false;
-                ddRelativeTo.Visible = false;
+                tbRelativeTo.Visible = false;
                 lblSide.Visible = false;
-                ddSide.Visible = false;
+                rgSide.Visible = false;
 
                 lblValue.Y = 1;
                 lblValue.Visible = true;
@@ -138,9 +144,9 @@ private void SetupForCurrentPosType()
                 break;
             case PosType.Center:
                 lblRelativeTo.Visible = false;
-                ddRelativeTo.Visible = false;
+                tbRelativeTo.Visible = false;
                 lblSide.Visible = false;
-                ddSide.Visible = false;
+                rgSide.Visible = false;
 
                 lblValue.Visible = false;
                 tbValue.Visible = false;
@@ -154,10 +160,10 @@ private void SetupForCurrentPosType()
                 break;
             case PosType.Absolute:
             case PosType.AnchorEnd:
-                ddRelativeTo.Visible = false;
+                tbRelativeTo.Visible = false;
                 lblRelativeTo.Visible = false;
                 lblSide.Visible = false;
-                ddSide.Visible = false;
+                rgSide.Visible = false;
 
                 lblValue.Y = 1;
                 lblValue.Visible = true;
@@ -170,23 +176,23 @@ private void SetupForCurrentPosType()
             case PosType.Relative:
                 lblRelativeTo.Y = 1;
                 lblRelativeTo.Visible = true;
-                ddRelativeTo.Y = 1;
-                ddRelativeTo.Visible = true;
+                tbRelativeTo.Y = 1;
+                tbRelativeTo.Visible = true;
 
                 lblSide.Y = 3;
                 lblSide.Visible = true;
 
-                ddSide.IsInitialized = false;
-                ddSide.Y = 3;
-                ddSide.Visible = true;
-                ddSide.IsInitialized = true;
+                rgSide.IsInitialized = false;
+                rgSide.Y = 3;
+                rgSide.Visible = true;
+                rgSide.IsInitialized = true;
 
                 lblValue.Visible = false;
                 tbValue.Visible = false;
 
-                lblOffset.Y = 5;
+                lblOffset.Y = 7;
                 lblOffset.Visible = true;
-                tbOffset.Y = 5;
+                tbOffset.Y = 7;
                 tbOffset.Visible = true;
                 SetNeedsDraw();
                 break;
@@ -249,7 +255,7 @@ private PosType GetPosType()
 
     private Side? GetSide()
     {
-        return ddSide.SelectedItem == -1 ? null : (Side)ddSide.Source.ToList()[ddSide.SelectedItem];
+        return rgSide.SelectedItem == -1 ? null : (Side)rgSide.SelectedItem;
     }
 
     private bool GetOffset(out int offset)
@@ -274,7 +280,9 @@ private bool GetOffset(out int offset)
 
     private bool BuildPosRelative(out Pos result)
     {
-        var relativeTo = ddRelativeTo.SelectedItem == -1 ? null : ddRelativeTo.Source.ToList()[ddRelativeTo.SelectedItem] as Design;
+        var key = tbRelativeTo.Text;
+
+        var relativeTo = (!string.IsNullOrWhiteSpace(key)) && _siblings.TryGetValue(key, out var d) ? d : null;
 
         if (relativeTo != null)
         {

src/UI/Windows/PosEditor.cs

@@ -53,7 +53,10 @@ public static class ViewFactory
         typeof(Menuv2),
         typeof(ScrollBar),
         typeof(ScrollSlider),
-        typeof(TileView)
+        typeof(TileView),
+
+        // Terminal.Gui combo boxes do not really work properly
+        typeof(ComboBox)
     ];
 
     /// <summary>