Fix MenuBar editing to focus newly created menu items

Author: tznind

src/MenuBarExtensions.cs

@@ -154,6 +154,8 @@ public static void InsertMenuItem(this MenuItem menuItem, int index, MenuItem it
         var items = menuItem.GetMenuItems();
         items.Insert(Math.Min(index, items.Count), itemToInsert);
         menuItem.SetMenuItems(items);
+
+        itemToInsert.SetFocus();
     }
 
     /// <summary>

src/MenuTracker.cs

@@ -23,12 +23,6 @@ private MenuTracker()
     /// </summary>
     public static MenuTracker Instance { get; } = new();
 
-    /// <summary>
-    /// Gets the currently selected <see cref="MenuItem"/> if any.  To work
-    /// you must subscribe all <see cref="MenuBar"/> to this class so that
-    /// it can watch <see cref="MenuBar.MenuOpened"/> etc.
-    /// </summary>
-    public MenuItem? CurrentlyOpenMenuItem { get; private set; }
 
     /// <summary>
     /// Registers listeners for <paramref name="mb"/> to track open/close.
@@ -71,17 +65,6 @@ private void OnPopoverMenuOpenChanged(object? sender, ValueChangedEventArgs<bool
     {
         if (sender is MenuBarItem menuBarItem)
         {
-            if (e.NewValue) // Menu opened
-            {
-                // Set the currently open menu item to the MenuBarItem itself
-                // The KeyboardManager will use this to enable renaming
-                this.CurrentlyOpenMenuItem = menuBarItem;
-            }
-            else // Menu closed
-            {
-                this.CurrentlyOpenMenuItem = null;
-            }
-
             // Convert empty menus when closing
             if (!e.NewValue)
             {

src/UI/KeyboardManager.cs

@@ -111,8 +111,7 @@ private bool HandleKeyPressInMenu(View focusedView, MenuItem menuItem, Key keyst
             OperationManager.Instance.Do(
                     new AddMenuItemOperation(this.app, menuItem));
 
-            ChangeKeyTo(keystroke, Key.CursorDown);
-            return false;
+            return true;
         }
 
         if (keystroke.ToString( ) == this.keyMap.SetShortcut)