Fix e2e CI: remove old puppeteer screenshot step and port forward

The puppeteer-based screenshot was from the pre-framework approach and
fails because the container stops the QEMU port forward after tests
complete. Screenshots are now handled inside the container via the
hooks/screenshot.sh mechanism. Also remove KEEP_ALIVE and increase
the wait timeout to 25 minutes.

Author: guysoft

.github/workflows/build.yml

@@ -104,86 +104,26 @@ jobs:
           mkdir -p artifacts
           IMG=$(find image/ -name '*.img' | head -1)
           docker run -d --name octopi-test \
-            -p 9980:9980 \
             -v "$PWD/artifacts:/output" \
             -v "$(realpath $IMG):/input/image.img:ro" \
             -e ARTIFACTS_DIR=/output \
             -e DISTRO_NAME="OctoPi" \
-            -e KEEP_ALIVE=true \
             octopi-e2e-test
 
       - name: Wait for tests to complete
         run: |
-          for i in $(seq 1 180); do
+          for i in $(seq 1 300); do
             [ -f artifacts/exit-code ] && break
             sleep 5
           done
           if [ ! -f artifacts/exit-code ]; then
-            echo "ERROR: Tests did not complete within 15 minutes"
+            echo "ERROR: Tests did not complete within 25 minutes"
             docker logs octopi-test 2>&1 | tail -80
             exit 1
           fi
           echo "Tests finished with exit code: $(cat artifacts/exit-code)"
           cat artifacts/test-results.txt 2>/dev/null || true
 
-      - name: Wait for OctoPrint to fully start
-        run: |
-          echo "Waiting for OctoPrint to finish startup..."
-          for i in $(seq 1 90); do
-            BODY=$(curl -4 -s --connect-timeout 5 http://127.0.0.1:9980 2>/dev/null || true)
-            if echo "$BODY" | grep -q "CONFIG_WIZARD"; then
-              echo "OctoPrint fully started (Setup Wizard ready)"
-              exit 0
-            elif echo "$BODY" | grep -q "starting up"; then
-              printf "S"
-            else
-              printf "."
-            fi
-            sleep 5
-          done
-          echo ""
-          echo "WARNING: OctoPrint may not be fully started yet, proceeding anyway"
-
-      - name: Take OctoPrint screenshot
-        run: |
-          npm install puppeteer
-          node -e "
-            const puppeteer = require('puppeteer');
-            (async () => {
-              const browser = await puppeteer.launch({
-                headless: 'new', args: ['--no-sandbox']
-              });
-              const page = await browser.newPage();
-              await page.setViewport({width: 1280, height: 900});
-
-              // Retry loading until OctoPrint finishes its startup phase
-              for (let attempt = 0; attempt < 30; attempt++) {
-                await page.goto('http://127.0.0.1:9980', {
-                  waitUntil: 'networkidle2', timeout: 60000
-                });
-                const html = await page.content();
-                if (html.includes('CONFIG_WIZARD') || html.includes('id=\"login\"')) break;
-                console.log('OctoPrint still starting up, retrying in 10s... (attempt ' + (attempt+1) + ')');
-                await new Promise(r => setTimeout(r, 10000));
-              }
-
-              // Wait for the Setup Wizard dialog to appear
-              try {
-                await page.waitForSelector('#wizard_dialog', { visible: true, timeout: 120000 });
-              } catch (e) {
-                console.log('Wizard did not appear, taking screenshot of current state');
-              }
-
-              // Dismiss notification popovers by clicking the wizard body
-              try { await page.click('#wizard_dialog .modal-body'); } catch(e) {}
-              await new Promise(r => setTimeout(r, 2000));
-
-              await page.screenshot({path: 'artifacts/octoprint-screenshot.png'});
-              console.log('Screenshot captured');
-              await browser.close();
-            })();
-          "
-
       - name: Collect logs and stop container
         if: always()
         run: |