Wait for OctoPrint Setup Wizard before taking screenshot

The previous screenshot captured OctoPrint's "starting up" loading
screen instead of the actual UI. Now both the CI workflow and the
E2E test wait for OctoPrint to fully finish its startup phase by
checking for CONFIG_WIZARD in the page HTML, and puppeteer waits
for the #wizard_dialog to become visible before capturing.

Author: guysoft

.github/workflows/build.yml

@@ -111,14 +111,23 @@ jobs:
           echo "Tests finished with exit code: $(cat artifacts/exit-code)"
           cat artifacts/test-results.txt 2>/dev/null || true
 
-      - name: Wait for OctoPrint web server
+      - name: Wait for OctoPrint to fully start
         run: |
-          for i in $(seq 1 60); do
-            HTTP=$(curl -4 -s -o /dev/null -w '%{http_code}' \
-              --connect-timeout 5 http://127.0.0.1:9980 2>/dev/null || true)
-            [ "$HTTP" = "200" ] && echo "OctoPrint ready" && break
+          echo "Waiting for OctoPrint to finish startup..."
+          for i in $(seq 1 90); do
+            BODY=$(curl -4 -s --connect-timeout 5 http://127.0.0.1:9980 2>/dev/null || true)
+            if echo "$BODY" | grep -q "CONFIG_WIZARD"; then
+              echo "OctoPrint fully started (Setup Wizard ready)"
+              exit 0
+            elif echo "$BODY" | grep -q "starting up"; then
+              printf "S"
+            else
+              printf "."
+            fi
             sleep 5
           done
+          echo ""
+          echo "WARNING: OctoPrint may not be fully started yet, proceeding anyway"
 
       - name: Take OctoPrint screenshot
         run: |
@@ -131,10 +140,31 @@ jobs:
               });
               const page = await browser.newPage();
               await page.setViewport({width: 1280, height: 900});
-              await page.goto('http://127.0.0.1:9980', {
-                waitUntil: 'networkidle2', timeout: 60000
-              });
+
+              // Retry loading until OctoPrint finishes its startup phase
+              for (let attempt = 0; attempt < 30; attempt++) {
+                await page.goto('http://127.0.0.1:9980', {
+                  waitUntil: 'networkidle2', timeout: 60000
+                });
+                const html = await page.content();
+                if (html.includes('CONFIG_WIZARD') || html.includes('id=\"login\"')) break;
+                console.log('OctoPrint still starting up, retrying in 10s... (attempt ' + (attempt+1) + ')');
+                await new Promise(r => setTimeout(r, 10000));
+              }
+
+              // Wait for the Setup Wizard dialog to appear
+              try {
+                await page.waitForSelector('#wizard_dialog', { visible: true, timeout: 120000 });
+              } catch (e) {
+                console.log('Wizard did not appear, taking screenshot of current state');
+              }
+
+              // Dismiss notification popovers by clicking the wizard body
+              try { await page.click('#wizard_dialog .modal-body'); } catch(e) {}
+              await new Promise(r => setTimeout(r, 2000));
+
               await page.screenshot({path: 'artifacts/octoprint-screenshot.png'});
+              console.log('Screenshot captured');
               await browser.close();
             })();
           "

testing/tests/test_octoprint_web.sh

@@ -9,26 +9,35 @@ PASS="raspberry"
 
 SSH_CMD="sshpass -p $PASS ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o PreferredAuthentications=password -o PubkeyAuthentication=no -o LogLevel=ERROR -p $PORT ${USER}@${HOST}"
 
-echo "Test: OctoPrint web server is accessible"
+echo "Test: OctoPrint web server is accessible and fully started"
 
 OCTOPRINT_READY=0
-for i in $(seq 1 24); do
+for i in $(seq 1 60); do
+    BODY=$($SSH_CMD "curl -s http://localhost" 2>/dev/null || echo "")
     HTTP_CODE=$($SSH_CMD "curl -s -o /dev/null -w '%{http_code}' http://localhost" 2>/dev/null || echo "000")
+
     if [ "$HTTP_CODE" = "200" ]; then
-        OCTOPRINT_READY=1
-        break
+        if echo "$BODY" | grep -q "starting up"; then
+            printf "S"
+        elif echo "$BODY" | grep -q "CONFIG_WIZARD\|OctoPrint"; then
+            OCTOPRINT_READY=1
+            break
+        else
+            printf "W"
+        fi
+    else
+        printf "."
     fi
-    printf "W"
     sleep 5
 done
 echo ""
 
 if [ "$OCTOPRINT_READY" -eq 0 ]; then
-    echo "  FAIL: OctoPrint web server not reachable after 120s"
+    echo "  FAIL: OctoPrint did not fully start within 300s"
     exit 1
 fi
 
-echo "  OctoPrint web server is ready (HTTP 200)"
+echo "  OctoPrint web server is fully started (HTTP 200, UI loaded)"
 
 FULL_HTML=$($SSH_CMD "curl -s http://localhost" 2>/dev/null)