Skip to content

Commit 57eda2e

Browse files
author
Ernesto Castellotti
authored
[HOT FIX] Regressions caused by PR #214 (#217)
1 parent 1a51b4c commit 57eda2e

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

assets/js/rootLantiq.js

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ async function waitEndImageLoad(port, baudRate, outputErrorCallback) {
213213
}
214214
}
215215

216-
await(1000);
216+
await delay(1000);
217217
await closePortLineBreak(port, reader, writer, readableStreamClosed, writerStreamClosed);
218218
return true;
219219
} catch (err) {
@@ -233,16 +233,23 @@ async function flashImageMtd(port, image, baudRate, outputErrorCallback) {
233233
} else {
234234
await writer.write(`sf probe 0 && sf erase ${IMAGE1_ADDR} && sf write ${LOAD_ADDR} ${IMAGE1_ADDR} && setenv committed_image 1 && setenv image1_is_valid 1 && saveenv && reset\n`);
235235
}
236+
} catch (err) {
237+
outputErrorCallback(`Error: ${err.message}`);
238+
return false;
239+
} finally {
240+
await closePortLineBreak(port, reader, writer, readableStreamClosed, writerStreamClosed);
241+
}
236242

237-
await delay(1000);
238-
243+
const serial = new SerialReadWrite(port, baudRate);
244+
try {
239245
/* Wait to avoid the user from disconnecting the SFP while the image is being flashed */
240-
await detectUboot(reader);
241-
await closePortLineBreak(port, reader, writer, readableStreamClosed, writerStreamClosed);
246+
await delay(1000);
247+
await detectUboot(serial);
242248
return true;
243249
} catch (err) {
244250
outputErrorCallback(`Error: ${err.message}`);
245-
await closePortLineBreak(port, reader, writer, readableStreamClosed, writerStreamClosed);
246251
return false;
252+
} finally {
253+
await serial.closePort();
247254
}
248255
}

assets/js/serialUtil.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ class SerialReadWrite {
103103
writer = this.port.writable.getWriter();
104104
}
105105

106-
writer.write(textEncoder.encode(str));
106+
writer.write(this.textEncoder.encode(str));
107107
} finally {
108108
if (writer) {
109109
writer.releaseLock();

0 commit comments

Comments
 (0)