Skip to content

XS✔ ◾ fix app version label when image tag is overridden #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimoschi merged 1 commit into from
Apr 28, 2026
Merged

XS✔ ◾ fix app version label when image tag is overridden #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,22 @@ Create chart name and version as used by the chart label.
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }}
{{- end }}

{{/*
Resolve the effective Typesense application version.
*/}}
{{- define "typesense.appVersion" -}}
{{- .Values.image.tag | default .Chart.AppVersion -}}
{{- end }}

{{/*
Common labels
*/}}
{{- define "typesense.labels" -}}
helm.sh/chart: {{ include "typesense.chart" . }}
{{ include "typesense.selectorLabels" . }}
{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- $appVersion := include "typesense.appVersion" . }}
{{- if $appVersion }}
app.kubernetes.io/version: {{ $appVersion | quote }}
{{- end }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- if .Chart.Annotations.team }}
Expand Down Expand Up @@ -104,4 +112,4 @@ Create the nodeslist
{{- $nodes = append $nodes $node }}
{{- end }}
{{- $nodes | join "," }}
{{- end }}
{{- end }}
12 changes: 12 additions & 0 deletions tests/statefulset_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,18 @@ tests:
- equal:
path: .spec.replicas
value: 5
- it: should use the effective image tag for app version labels when overridden
set:
image:
tag: "26.0"
asserts:
- notFailedTemplate: {}
- equal:
path: .spec.template.metadata.labels["app.kubernetes.io/version"]
value: "26.0"
- equal:
path: .spec.template.spec.containers[0].image
value: typesense/typesense:26.0
- it: should reject even replica counts greater than 1
set:
replicaCount: 4
Expand Down
Loading