Merge branch 'release/0.3.4'

IvanChepurnyi · IvanChepurnyi · commit c2c493f46ef0 · 2014-10-15T17:05:26.000+02:00
diff --git a/app/code/community/EcomDev/PHPUnit/Controller/Request/Http.php b/app/code/community/EcomDev/PHPUnit/Controller/Request/Http.php
@@ -372,7 +372,7 @@ public function getHttpHost($trimPort = false)
      *
      * @see Mage_Core_Controller_Request_Http::getBaseUrl()
      */
-    public function getBaseUrl()
+    public function getBaseUrl($raw = false)
     {
         return $this->_baseUrl;
     }
diff --git a/app/code/community/EcomDev/PHPUnit/Model/Config.php b/app/code/community/EcomDev/PHPUnit/Model/Config.php
@@ -124,11 +124,11 @@ public function flushReplaceInstanceCreation()
      */
     public function getModelInstance($modelClass='', $constructArguments=array())
     {
-        if (!isset($this->_replaceInstanceCreation['model'][$modelClass])) {
-            return parent::getModelInstance($modelClass, $constructArguments);
+        if (!isset($this->_replaceInstanceCreation['model'][(string)$modelClass])) {
+            return parent::getModelInstance((string)$modelClass, $constructArguments);
         }
 
-        return $this->_replaceInstanceCreation['model'][$modelClass];
+        return $this->_replaceInstanceCreation['model'][(string)$modelClass];
     }
 
     /**
diff --git a/app/code/community/EcomDev/PHPUnit/Model/Fixture.php b/app/code/community/EcomDev/PHPUnit/Model/Fixture.php
@@ -301,7 +301,7 @@ public function isScopeDefault()
     public function loadByTestCase(PHPUnit_Framework_TestCase $testCase)
     {
         $fixtures = EcomDev_PHPUnit_Test_Case_Util::getAnnotationByNameFromClass(
-            get_class($testCase), 'loadFixture', array('class', 'method'), $testCase->getName(false)
+            get_class($testCase), 'loadFixture', array('method', 'class'), $testCase->getName(false)
         );
 
         $this->_loadFixtureFiles($fixtures, $testCase);
@@ -412,7 +412,7 @@ public function loadYaml($filePath)
         if (empty($this->_fixture)) {
             $this->_fixture = $data;
         } else {
-            $this->_fixture = array_merge_recursive($this->_fixture, $data);
+            $this->_fixture = array_replace_recursive($this->_fixture, $data);
         }
 
         return $this;
diff --git a/app/code/community/EcomDev/PHPUnit/Model/Fixture/Processor/Config.php b/app/code/community/EcomDev/PHPUnit/Model/Fixture/Processor/Config.php
@@ -173,6 +173,16 @@ protected function _setConfigNodeValue($path, $value)
             $value = $backend->getValue();
         }
 
+        if (is_array($value)) {
+            Mage::throwException(
+                sprintf(
+                    'There is a collision in configuration value %s. Got: %s',
+                    $path,
+                    print_r($value, true)
+                )
+            );
+        }
+        
         Mage::getConfig()->setNode($path, $value);
         return $this;
     }
diff --git a/app/code/community/EcomDev/PHPUnit/Model/Mysql4/Fixture/AbstractEav.php b/app/code/community/EcomDev/PHPUnit/Model/Mysql4/Fixture/AbstractEav.php
@@ -112,7 +112,7 @@ public function loadEntity($entityType, $values)
         $this->_originalIndexers = $this->_requiredIndexers;
         if (!empty($this->_options['addRequiredIndex'])) {
             foreach ($this->_options['addRequiredIndex'] as $data) {
-                if (preg_match('/^([a-z0-9_\\-])+\\s+([a-z0-9_\\-])\s*$/i', $data, $match)
+                if (preg_match('/^([a-z0-9_\\-]+)\\s+([a-z0-9_\\-]+)\s*$/i', $data, $match)
                     && $match[1] == $entityType) {
                     $this->_requiredIndexers[] = $match[2];
                 }
diff --git a/app/code/community/EcomDev/PHPUnit/Test/Suite.php b/app/code/community/EcomDev/PHPUnit/Test/Suite.php
@@ -50,6 +50,8 @@ public static function suite()
 
         $suite = new self('Magento Test Suite');
 
+        $excludedModules = Mage::getConfig()->getNode('phpunit/suite/exclude');
+        
         // Walk through different groups in modules for finding test cases
         foreach ($groups->children() as $group) {
             foreach ($modules->children() as $module) {
@@ -58,6 +60,10 @@ public static function suite()
                     $suite->addTest(self::warning('There is no module with name: ' . $module->getName()));
                     continue;
                 }
+                
+                if (isset($excludedModules->{$module->getName()})) {
+                    continue;
+                }
 
                 $moduleCodeDir = Mage::getBaseDir('code') . DS . (string) $realModule->codePool;
                 $searchPath = Mage::getModuleDir('', $module->getName()) . DS . 'Test' . DS . (string) $group;
diff --git a/app/code/community/EcomDev/PHPUnit/Test/Suite/Group.php b/app/code/community/EcomDev/PHPUnit/Test/Suite/Group.php
@@ -68,9 +68,18 @@ public function __construct($theClass = '', $groups = array())
                  * impossibility for specifying group by parent test case
                  * Because it is a very dirty hack :(
                  **/
-                $testGroups = array();
+                $testGroups = EcomDev_Utils_Reflection::getRestrictedPropertyValue($test, 'groups');
+
                 foreach ($groups as $group) {
-                    $testGroups[$group] = $test->tests();
+                    if(!isset($testGroups[$group])) {
+                        $testGroups[$group] = $test->tests();
+                    } else {
+                        foreach($test->tests() as $subTest) {
+                            if(!in_array($subTest, $testGroups[$group], true)) {
+                                $testGroups[$group][] = $subTest;
+                            }
+                        }
+                    }
                 }
 
                 EcomDev_Utils_Reflection::setRestrictedPropertyValue(
diff --git a/app/code/community/EcomDev/PHPUnit/etc/config.xml b/app/code/community/EcomDev/PHPUnit/etc/config.xml
@@ -55,6 +55,8 @@
     </global>
     <phpunit>
         <suite>
+            <modules /> <!-- List of modules included into test suite -->
+            <exclude /> <!-- List of modules that are excluded from test suite -->
             <yaml>
                 <model>ecomdev_phpunit/yaml_loader</model>
                 <loaders>
diff --git a/app/code/community/EcomDev/PHPUnitTest/Test/Model/Fixture.php b/app/code/community/EcomDev/PHPUnitTest/Test/Model/Fixture.php
@@ -0,0 +1,37 @@
+<?php
+/**
+ * @loadSharedFixture testFixtureArrayMerge.yaml
+ */
+class EcomDev_PHPUnitTest_Test_Model_Fixture extends EcomDev_PHPUnit_Test_Case
+{
+
+    public function testFixtureArrayMerge()
+    {
+        require_once($this->_getVfsUrl('app/code/community/EcomDev/PHPUnit/Test/Model/ExampleClass.php'));
+
+        $testCase = new EcomDev_PHPUnitTest_Test_Model_ExampleClass();
+        $testCase->setName('testLoadFixtureOrder');
+        $this->getFixture()->loadForClass(get_class($testCase));
+        $this->getFixture()->loadByTestCase($testCase);
+        $this->getFixture()->apply();
+    }
+
+    public function testLoadClassBeforeMethodFixtures()
+    {
+        require_once($this->_getVfsUrl('app/code/community/EcomDev/PHPUnit/Test/Model/ExampleClass.php'));
+
+        $testCase = new EcomDev_PHPUnitTest_Test_Model_ExampleClass();
+        $testCase->setName('testLoadFixtureOrder');
+        $this->getFixture()->loadForClass(get_class($testCase));
+        $this->getFixture()->loadByTestCase($testCase);
+        $this->getFixture()->apply();
+        $this->assertEquals('methodFixtureValue', Mage::getStoreConfig('sample/path'));
+    }
+
+    protected function _getVfsUrl($path)
+    {
+        return $this->getFixture()->getVfs()->url($path);
+    }
+
+
+}
diff --git a/app/code/community/EcomDev/PHPUnitTest/Test/Model/Fixture/fixtures/testFixtureArrayMerge.yaml b/app/code/community/EcomDev/PHPUnitTest/Test/Model/Fixture/fixtures/testFixtureArrayMerge.yaml
@@ -0,0 +1,39 @@
+vfs:
+  app:
+    code:
+      community:
+        EcomDev:
+          PHPUnit:
+            Test:
+              Model:
+                ExampleClass.php: |
+                                    <?php
+
+                                      /**
+                                       * @loadSharedFixture sharedClassFixture.yaml
+                                       * @loadFixture classFixture.yaml
+                                       */
+                                      class EcomDev_PHPUnitTest_Test_Model_ExampleClass extends EcomDev_PHPUnit_Test_Case
+                                      {
+                                          /**
+                                           * @loadSharedFixture sharedMethodFixture.yaml
+                                           * @loadFixture methodFixture.yaml
+                                           */
+                                          public function testLoadFixtureOrder()
+                                          {
+
+                                          }
+                                      }
+                fixtures:
+                  classFixture.yaml: >
+                    config:
+                      default/sample/path: classFixtureValue
+                  sharedClassFixture.yaml: >
+                     config:
+                       default/sample/path: sharedClassFixtureValue
+                  sharedMethodFixture.yaml: >
+                     config:
+                       default/sample/path: sharedMethodFixtureValue
+                  methodFixture.yaml: >
+                     config:
+                       default/sample/path: methodFixtureValue
diff --git a/composer.json b/composer.json
@@ -8,6 +8,9 @@
         "magento-hackathon/magento-composer-installer": "*",
         "phpunit/phpunit": "4.1.*"
     },
+    "replace": {
+        "ivanchepurnyi/ecomdev_phpunit":"*"
+    },
     "authors":[
         {
             "name":"Ivan Chepurnyi"
diff --git a/lib/EcomDev/PHPUnit/Constraint/Layout/Block/Property.php b/lib/EcomDev/PHPUnit/Constraint/Layout/Block/Property.php
@@ -81,7 +81,7 @@ public function count()
      * (non-PHPdoc)
      * @see EcomDev_PHPUnit_ConstraintAbstract::getActualValue()
      */
-    protected function getActualValue($other)
+    protected function getActualValue($other = null)
     {
         if ($this->_useActualValue) {
             if ($this->_actualValue instanceof Varien_Object) {

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ public function getHttpHost($trimPort = false)`
`372`	`372`	`*`
`373`	`373`	`* @see Mage_Core_Controller_Request_Http::getBaseUrl()`
`374`	`374`	`*/`
`375`		`- public function getBaseUrl()`
	`375`	`+ public function getBaseUrl($raw = false)`
`376`	`376`	`{`
`377`	`377`	`return $this->_baseUrl;`
`378`	`378`	`}`
Original file line number	Diff line number	Diff line change
`@@ -124,11 +124,11 @@ public function flushReplaceInstanceCreation()`
`124`	`124`	`*/`
`125`	`125`	`public function getModelInstance($modelClass='', $constructArguments=array())`
`126`	`126`	`{`
`127`		`- if (!isset($this->_replaceInstanceCreation['model'][$modelClass])) {`
`128`		`- return parent::getModelInstance($modelClass, $constructArguments);`
	`127`	`+ if (!isset($this->_replaceInstanceCreation['model'][(string)$modelClass])) {`
	`128`	`+ return parent::getModelInstance((string)$modelClass, $constructArguments);`
`129`	`129`	`}`
`130`	`130`
`131`		`- return $this->_replaceInstanceCreation['model'][$modelClass];`
	`131`	`+ return $this->_replaceInstanceCreation['model'][(string)$modelClass];`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function loadEntity($entityType, $values)`
`112`	`112`	`$this->_originalIndexers = $this->_requiredIndexers;`
`113`	`113`	`if (!empty($this->_options['addRequiredIndex'])) {`
`114`	`114`	`foreach ($this->_options['addRequiredIndex'] as $data) {`
`115`		`- if (preg_match('/^([a-z0-9_\\-])+\\s+([a-z0-9_\\-])\s*$/i', $data, $match)`
	`115`	`+ if (preg_match('/^([a-z0-9_\\-]+)\\s+([a-z0-9_\\-]+)\s*$/i', $data, $match)`
`116`	`116`	`&& $match[1] == $entityType) {`
`117`	`117`	`$this->_requiredIndexers[] = $match[2];`
`118`	`118`	`}`