fix(consensus): use Locale.ROOT for case-insensitive string operations

halibobo1205 · claude · halibobo1205 · commit 05bfab22f0ea · 2026-04-12T16:00:23.000+08:00
String.toLowerCase()/toUpperCase() without an explicit Locale uses
Locale.getDefault(), which on Turkish (tr) or Azerbaijani (az) systems
folds 'I' to dotless-ı (U+0131) instead of 'i' (U+0069). This caused
AccountIdIndexStore to generate different index keys on tr/az nodes,
enabling a consensus split where tr/az nodes accept duplicate accountId
transactions that other nodes reject.

Fix AccountIdIndexStore.getLowerCaseAccountId to use Locale.ROOT, and
add a legacy fallback in get()/has() so that tr/az nodes can still
read old data stored with the locale-sensitive key.

Also fix all other toLowerCase()/toUpperCase() calls across the
codebase and enable the built-in ErrorProne StringCaseLocaleUsage
checker at ERROR level to prevent future regressions at compile time.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/actuator/src/main/java/org/tron/core/actuator/AssetIssueActuator.java b/actuator/src/main/java/org/tron/core/actuator/AssetIssueActuator.java
@@ -22,6 +22,7 @@
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Objects;
 import lombok.extern.slf4j.Slf4j;
 import org.tron.common.math.StrictMathWrapper;
@@ -166,7 +167,7 @@ public boolean validate() throws ContractValidateException {
     }
 
     if (dynamicStore.getAllowSameTokenName() != 0) {
-      String name = assetIssueContract.getName().toStringUtf8().toLowerCase();
+      String name = assetIssueContract.getName().toStringUtf8().toLowerCase(Locale.ROOT);
       if (("trx").equals(name)) {
         throw new ContractValidateException("assetName can't be trx");
       }
diff --git a/build.gradle b/build.gradle
@@ -1,10 +1,16 @@
 import org.gradle.nativeplatform.platform.internal.Architectures
 import org.gradle.internal.os.OperatingSystem
+
+plugins {
+    id 'net.ltgt.errorprone' version '5.0.0' apply false
+}
+
 allprojects {
     version = "1.0.0"
     apply plugin: "java-library"
     ext {
         springVersion = "5.3.39"
+        errorproneVersion = "2.42.0"
     }
 }
 def arch = System.getProperty("os.arch").toLowerCase()
@@ -107,6 +113,23 @@ subprojects {
         testImplementation "org.mockito:mockito-core:4.11.0"
         testImplementation "org.mockito:mockito-inline:4.11.0"
     }
+    if (project.name != 'protocol') {
+        apply plugin: 'net.ltgt.errorprone'
+        dependencies {
+            errorprone "com.google.errorprone:error_prone_core:${errorproneVersion}"
+        }
+        tasks.withType(JavaCompile).configureEach {
+            options.errorprone {
+                enabled = true
+                disableWarningsInGeneratedCode = true
+                disableAllChecks = true
+                excludedPaths = '.*/generated/.*'
+                errorproneArgs.addAll([
+                        '-Xep:StringCaseLocaleUsage:ERROR',
+                ])
+            }
+        }
+    }
 
     task sourcesJar(type: Jar, dependsOn: classes) {
         classifier = "sources"
diff --git a/chainbase/src/main/java/org/tron/core/db/TronDatabase.java b/chainbase/src/main/java/org/tron/core/db/TronDatabase.java
@@ -2,6 +2,7 @@
 
 import com.google.protobuf.InvalidProtocolBufferException;
 import java.nio.file.Paths;
+import java.util.Locale;
 import java.util.Iterator;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -37,10 +38,10 @@ protected TronDatabase(String dbName) {
     this.dbName = dbName;
 
     if ("LEVELDB".equals(CommonParameter.getInstance().getStorage()
-        .getDbEngine().toUpperCase())) {
+        .getDbEngine().toUpperCase(Locale.ROOT))) {
       dbSource = new LevelDbDataSourceImpl(StorageUtils.getOutputDirectoryByDbName(dbName), dbName);
     } else if ("ROCKSDB".equals(CommonParameter.getInstance()
-        .getStorage().getDbEngine().toUpperCase())) {
+        .getStorage().getDbEngine().toUpperCase(Locale.ROOT))) {
       String parentName = Paths.get(StorageUtils.getOutputDirectoryByDbName(dbName),
           CommonParameter.getInstance().getStorage().getDbDirectory()).toString();
       dbSource = new RocksDbDataSourceImpl(parentName, dbName);
diff --git a/chainbase/src/main/java/org/tron/core/db/TronStoreWithRevoking.java b/chainbase/src/main/java/org/tron/core/db/TronStoreWithRevoking.java
@@ -5,6 +5,7 @@
 import com.google.common.collect.Streams;
 import com.google.common.reflect.TypeToken;
 import java.io.IOException;
+import java.util.Locale;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
 import java.nio.file.Paths;
@@ -54,10 +55,10 @@ public abstract class TronStoreWithRevoking<T extends ProtoCapsule> implements I
 
   protected TronStoreWithRevoking(String dbName) {
     String dbEngine = CommonParameter.getInstance().getStorage().getDbEngine();
-    if ("LEVELDB".equals(dbEngine.toUpperCase())) {
+    if ("LEVELDB".equals(dbEngine.toUpperCase(Locale.ROOT))) {
       this.db =  new LevelDB(
           new LevelDbDataSourceImpl(StorageUtils.getOutputDirectoryByDbName(dbName), dbName));
-    } else if ("ROCKSDB".equals(dbEngine.toUpperCase())) {
+    } else if ("ROCKSDB".equals(dbEngine.toUpperCase(Locale.ROOT))) {
       String parentPath = Paths
           .get(StorageUtils.getOutputDirectoryByDbName(dbName), CommonParameter
               .getInstance().getStorage().getDbDirectory()).toString();
diff --git a/chainbase/src/main/java/org/tron/core/db2/common/TxCacheDB.java b/chainbase/src/main/java/org/tron/core/db2/common/TxCacheDB.java
@@ -20,6 +20,7 @@
 import java.nio.file.Paths;
 import java.nio.file.StandardOpenOption;
 import java.util.Iterator;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Objects;
@@ -102,10 +103,10 @@ public TxCacheDB(String name, RecentTransactionStore recentTransactionStore,
     this.recentTransactionStore = recentTransactionStore;
     this.dynamicPropertiesStore = dynamicPropertiesStore;
     String dbEngine = CommonParameter.getInstance().getStorage().getDbEngine();
-    if ("LEVELDB".equals(dbEngine.toUpperCase())) {
+    if ("LEVELDB".equals(dbEngine.toUpperCase(Locale.ROOT))) {
       this.persistentStore = new LevelDB(
           new LevelDbDataSourceImpl(StorageUtils.getOutputDirectoryByDbName(name), name));
-    } else if ("ROCKSDB".equals(dbEngine.toUpperCase())) {
+    } else if ("ROCKSDB".equals(dbEngine.toUpperCase(Locale.ROOT))) {
       String parentPath = Paths
           .get(StorageUtils.getOutputDirectoryByDbName(name), CommonParameter
               .getInstance().getStorage().getDbDirectory()).toString();
diff --git a/chainbase/src/main/java/org/tron/core/store/AccountIdIndexStore.java b/chainbase/src/main/java/org/tron/core/store/AccountIdIndexStore.java
@@ -1,6 +1,8 @@
 package org.tron.core.store;
 
 import com.google.protobuf.ByteString;
+import java.util.Arrays;
+import java.util.Locale;
 import java.util.Objects;
 import org.apache.commons.lang3.ArrayUtils;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -19,9 +21,32 @@ public AccountIdIndexStore(@Value("accountid-index") String dbName) {
     super(dbName);
   }
 
-  private static byte[] getLowerCaseAccountId(byte[] bsAccountId) {
+  public static byte[] getLowerCaseAccountId(byte[] bsAccountId) {
     return ByteString
-        .copyFromUtf8(ByteString.copyFrom(bsAccountId).toStringUtf8().toLowerCase()).toByteArray();
+        .copyFromUtf8(ByteString.copyFrom(bsAccountId).toStringUtf8().toLowerCase(Locale.ROOT))
+        .toByteArray();
+  }
+
+  /**
+   * Get the legacy lower-case key using the system default Locale.
+   * Only differs from {@link #getLowerCaseAccountId} on tr/az locales,
+   * where 'I' maps to 'ı' (U+0131) instead of 'i' (U+0069).
+   */
+  @SuppressWarnings("StringCaseLocaleUsage")
+  private static byte[] getLegacyLowerCaseAccountId(byte[] bsAccountId) {
+    return ByteString
+        .copyFromUtf8(ByteString.copyFrom(bsAccountId).toStringUtf8().toLowerCase())
+        .toByteArray();
+  }
+
+  /**
+   * Check whether the legacy key differs from the standard key.
+   * True only when the system Locale is tr or az and the input contains
+   * characters affected by locale-sensitive case folding (e.g. 'I').
+   */
+  private static boolean hasLegacyKey(byte[] standardKey, byte[] bsAccountId) {
+    byte[] legacyKey = getLegacyLowerCaseAccountId(bsAccountId);
+    return !Arrays.equals(standardKey, legacyKey);
   }
 
   public void put(AccountCapsule accountCapsule) {
@@ -41,6 +66,9 @@ public byte[] get(ByteString name) {
   public BytesCapsule get(byte[] key) {
     byte[] lowerCaseKey = getLowerCaseAccountId(key);
     byte[] value = revokingDB.getUnchecked(lowerCaseKey);
+    if (ArrayUtils.isEmpty(value) && hasLegacyKey(lowerCaseKey, key)) {
+      value = revokingDB.getUnchecked(getLegacyLowerCaseAccountId(key));
+    }
     if (ArrayUtils.isEmpty(value)) {
       return null;
     }
@@ -51,7 +79,10 @@ public BytesCapsule get(byte[] key) {
   public boolean has(byte[] key) {
     byte[] lowerCaseKey = getLowerCaseAccountId(key);
     byte[] value = revokingDB.getUnchecked(lowerCaseKey);
+    if (ArrayUtils.isEmpty(value) && hasLegacyKey(lowerCaseKey, key)) {
+      value = revokingDB.getUnchecked(getLegacyLowerCaseAccountId(key));
+    }
     return !ArrayUtils.isEmpty(value);
   }
 
-}
+}
diff --git a/common/src/main/java/org/tron/common/args/Account.java b/common/src/main/java/org/tron/common/args/Account.java
@@ -17,6 +17,7 @@
 
 import com.google.protobuf.ByteString;
 import java.io.Serializable;
+import java.util.Locale;
 import lombok.Getter;
 import org.apache.commons.lang3.StringUtils;
 import org.tron.common.utils.ByteArray;
@@ -120,7 +121,7 @@ public boolean isAccountType(final String accountType) {
       return false;
     }
 
-    switch (accountType.toUpperCase()) {
+    switch (accountType.toUpperCase(Locale.ROOT)) {
       case ACCOUNT_TYPE_NORMAL:
       case ACCOUNT_TYPE_ASSETISSUE:
       case ACCOUNT_TYPE_CONTRACT:
@@ -138,7 +139,7 @@ public AccountType getAccountTypeByString(final String accountType) {
       throw new IllegalArgumentException("Account type error: Not a Normal/AssetIssue/Contract");
     }
 
-    switch (accountType.toUpperCase()) {
+    switch (accountType.toUpperCase(Locale.ROOT)) {
       case ACCOUNT_TYPE_NORMAL:
         return AccountType.Normal;
       case ACCOUNT_TYPE_ASSETISSUE:
diff --git a/common/src/main/java/org/tron/common/runtime/vm/DataWord.java b/common/src/main/java/org/tron/common/runtime/vm/DataWord.java
@@ -23,6 +23,7 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonValue;
 import java.math.BigInteger;
+import java.util.Locale;
 import java.nio.ByteBuffer;
 import org.bouncycastle.util.Arrays;
 import org.bouncycastle.util.encoders.Hex;
@@ -121,7 +122,7 @@ public static boolean isZero(byte[] data) {
 
   public static String shortHex(byte[] data) {
     byte[] bytes = ByteUtil.stripLeadingZeroes(data);
-    String hexValue = Hex.toHexString(bytes).toUpperCase();
+    String hexValue = Hex.toHexString(bytes).toUpperCase(Locale.ROOT);
     return "0x" + hexValue.replaceFirst("^0+(?!$)", "");
   }
 
@@ -451,7 +452,7 @@ public String toPrefixString() {
   }
 
   public String shortHex() {
-    String hexValue = Hex.toHexString(getNoLeadZeroesData()).toUpperCase();
+    String hexValue = Hex.toHexString(getNoLeadZeroesData()).toUpperCase(Locale.ROOT);
     return "0x" + hexValue.replaceFirst("^0+(?!$)", "");
   }
 
diff --git a/framework/src/main/java/org/tron/core/Wallet.java b/framework/src/main/java/org/tron/core/Wallet.java
@@ -57,6 +57,7 @@
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Objects;
@@ -3880,14 +3881,14 @@ private int getShieldedTRC20LogType(TransactionInfo.Log log, byte[] contractAddr
         for (String topic : topicsList) {
           byte[] topicHash = Hash.sha3(ByteArray.fromString(topic));
           if (Arrays.equals(topicsBytes, topicHash)) {
-            if (topic.toLowerCase().contains("mint")) {
+            if (topic.toLowerCase(Locale.ROOT).contains("mint")) {
               return 1;
-            } else if (topic.toLowerCase().contains("transfer")) {
+            } else if (topic.toLowerCase(Locale.ROOT).contains("transfer")) {
               return 2;
-            } else if (topic.toLowerCase().contains("burn")) {
-              if (topic.toLowerCase().contains("leaf")) {
+            } else if (topic.toLowerCase(Locale.ROOT).contains("burn")) {
+              if (topic.toLowerCase(Locale.ROOT).contains("leaf")) {
                 return 3;
-              } else if (topic.toLowerCase().contains("token")) {
+              } else if (topic.toLowerCase(Locale.ROOT).contains("token")) {
                 return 4;
               }
             }
diff --git a/framework/src/main/java/org/tron/core/config/args/Args.java b/framework/src/main/java/org/tron/core/config/args/Args.java
@@ -35,6 +35,7 @@
 import java.util.HashSet;
 import java.util.LinkedHashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
@@ -1770,7 +1771,7 @@ public static void printHelp(JCommander jCommander) {
     Map<String, String[]> groupOptionListMap = Args.getOptionGroup();
     for (Map.Entry<String, String[]> entry : groupOptionListMap.entrySet()) {
       String group = entry.getKey();
-      helpStr.append(String.format("%n%s OPTIONS:%n", group.toUpperCase()));
+      helpStr.append(String.format("%n%s OPTIONS:%n", group.toUpperCase(Locale.ROOT)));
       int optionMaxLength = Arrays.stream(entry.getValue()).mapToInt(p -> {
         ParameterDescription tmpParameterDescription = stringParameterDescriptionMap.get(p);
         if (tmpParameterDescription == null) {
@@ -1810,7 +1811,7 @@ public static String upperFirst(String name) {
     if (name.length() <= 1) {
       return name;
     }
-    name = name.substring(0, 1).toUpperCase() + name.substring(1);
+    name = name.substring(0, 1).toUpperCase(Locale.ROOT) + name.substring(1);
     return name;
   }
 
diff --git a/framework/src/main/java/org/tron/core/services/filter/HttpApiAccessFilter.java b/framework/src/main/java/org/tron/core/services/filter/HttpApiAccessFilter.java
@@ -3,6 +3,7 @@
 import com.alibaba.fastjson.JSONObject;
 import java.net.URI;
 import java.util.List;
+import java.util.Locale;
 import javax.servlet.Filter;
 import javax.servlet.FilterChain;
 import javax.servlet.FilterConfig;
@@ -63,7 +64,7 @@ private boolean isDisabled(String endpoint) {
       endpoint = URI.create(endpoint).normalize().toString();
       List<String> disabledApiList = CommonParameter.getInstance().getDisabledApiList();
       if (!disabledApiList.isEmpty()) {
-        disabled = disabledApiList.contains(endpoint.split("/")[2].toLowerCase());
+        disabled = disabledApiList.contains(endpoint.split("/")[2].toLowerCase(Locale.ROOT));
       }
     } catch (Exception e) {
       logger.warn("check isDisabled except, endpoint={}, {}", endpoint, e.getMessage());
diff --git a/framework/src/main/java/org/tron/core/services/http/Util.java b/framework/src/main/java/org/tron/core/services/http/Util.java
@@ -22,6 +22,7 @@
 import java.security.InvalidParameterException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Objects;
 import javax.servlet.http.HttpServletRequest;
@@ -525,10 +526,10 @@ public static byte[] getAddress(HttpServletRequest request) throws Exception {
   private static String checkGetParam(HttpServletRequest request, String key) throws Exception {
     String method = request.getMethod();
 
-    if (HttpMethod.GET.toString().toUpperCase().equalsIgnoreCase(method)) {
+    if (HttpMethod.GET.toString().toUpperCase(Locale.ROOT).equalsIgnoreCase(method)) {
       return request.getParameter(key);
     }
-    if (HttpMethod.POST.toString().toUpperCase().equals(method)) {
+    if (HttpMethod.POST.toString().toUpperCase(Locale.ROOT).equals(method)) {
       String contentType = request.getContentType();
       if (StringUtils.isBlank(contentType)) {
         return null;
diff --git a/framework/src/main/java/org/tron/core/services/ratelimiter/RpcApiAccessInterceptor.java b/framework/src/main/java/org/tron/core/services/ratelimiter/RpcApiAccessInterceptor.java
@@ -7,6 +7,7 @@
 import io.grpc.ServerInterceptor;
 import io.grpc.Status;
 import java.util.List;
+import java.util.Locale;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Component;
 import org.tron.common.parameter.CommonParameter;
@@ -43,7 +44,7 @@ private boolean isDisabled(String endpoint) {
     try {
       List<String> disabledApiList = CommonParameter.getInstance().getDisabledApiList();
       if (!disabledApiList.isEmpty()) {
-        disabled = disabledApiList.contains(endpoint.split("/")[1].toLowerCase());
+        disabled = disabledApiList.contains(endpoint.split("/")[1].toLowerCase(Locale.ROOT));
       }
     } catch (Exception e) {
       logger.error("check isDisabled except, endpoint={}, error is {}", endpoint, e.getMessage());
diff --git a/framework/src/main/java/org/tron/keystore/WalletUtils.java b/framework/src/main/java/org/tron/keystore/WalletUtils.java
@@ -12,6 +12,7 @@
 import java.time.ZoneOffset;
 import java.time.ZonedDateTime;
 import java.time.format.DateTimeFormatter;
+import java.util.Locale;
 import java.util.Scanner;
 import org.apache.commons.lang3.StringUtils;
 import org.tron.common.crypto.SignInterface;
@@ -94,7 +95,7 @@ public static String getDefaultKeyDirectory() {
   }
 
   static String getDefaultKeyDirectory(String osName1) {
-    String osName = osName1.toLowerCase();
+    String osName = osName1.toLowerCase(Locale.ROOT);
 
     if (osName.startsWith("mac")) {
       return String.format(
diff --git a/framework/src/main/java/org/tron/program/KeystoreFactory.java b/framework/src/main/java/org/tron/program/KeystoreFactory.java
@@ -2,6 +2,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.Locale;
 import java.util.Scanner;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.lang3.StringUtils;
@@ -114,7 +115,7 @@ private void run() {
         if ("".equals(cmd)) {
           continue;
         }
-        String cmdLowerCase = cmd.toLowerCase();
+        String cmdLowerCase = cmd.toLowerCase(Locale.ROOT);
 
         switch (cmdLowerCase) {
           case "help": {
diff --git a/framework/src/test/java/org/tron/common/cron/CronExpressionTest.java b/framework/src/test/java/org/tron/common/cron/CronExpressionTest.java
@@ -161,6 +161,7 @@ public void testLastDayOffset() throws Exception {
 
   }
 
+  @SuppressWarnings("StringCaseLocaleUsage")
   @Test
   public void testQuartz() throws Exception {
     CronExpression cronExpression = new CronExpression("19 15 10 4 Apr ? ");
diff --git a/framework/src/test/java/org/tron/common/crypto/SM2KeyTest.java b/framework/src/test/java/org/tron/common/crypto/SM2KeyTest.java
@@ -116,6 +116,7 @@ public void testInvalidSignatureLength() throws SignatureException {
     fail("Expecting a SignatureException for invalid signature length");
   }
 
+  @SuppressWarnings("StringCaseLocaleUsage")
   @Test
   public void testSM3Hash() {
     SM2 key = SM2.fromPublicOnly(pubKey);
diff --git a/framework/src/test/java/org/tron/common/runtime/vm/BytecodeCompiler.java b/framework/src/test/java/org/tron/common/runtime/vm/BytecodeCompiler.java
diff --git a/framework/src/test/java/org/tron/common/runtime/vm/OperationsTest.java b/framework/src/test/java/org/tron/common/runtime/vm/OperationsTest.java
diff --git a/framework/src/test/java/org/tron/common/utils/client/utils/DataWord.java b/framework/src/test/java/org/tron/common/utils/client/utils/DataWord.java
diff --git a/framework/src/test/java/org/tron/core/db/AccountIdIndexStoreTest.java b/framework/src/test/java/org/tron/core/db/AccountIdIndexStoreTest.java
diff --git a/framework/src/test/java/org/tron/core/zksnark/ShieldedReceiveTest.java b/framework/src/test/java/org/tron/core/zksnark/ShieldedReceiveTest.java
diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml
diff --git a/platform/src/main/java/common/org/tron/common/arch/Arch.java b/platform/src/main/java/common/org/tron/common/arch/Arch.java
diff --git a/settings.gradle b/settings.gradle
