Fix decoding error in Kvaser constructor for non-ASCII product name (#1613)

* Implement test to trigger ASCII decoding error in Kvaser bus constructor

* Change handling of invalid chars in Kvaser device name

Previously, illegal characters triggered an exception.
With the new behavior, illegal characters will be replaced
with a placeholder value.

* Rename variables in test

Author: lumagi

can/interfaces/kvaser/canlib.py

@@ -722,7 +722,8 @@ def get_channel_info(channel):
         ctypes.sizeof(number),
     )
 
-    return f"{name.value.decode('ascii')}, S/N {serial.value} (#{number.value + 1})"
+    name_decoded = name.value.decode("ascii", errors="replace")
+    return f"{name_decoded}, S/N {serial.value} (#{number.value + 1})"
 
 
 init_kvaser_library()

test/test_kvaser.py

@@ -3,6 +3,7 @@
 """
 """
 
+import ctypes
 import time
 import unittest
 from unittest.mock import Mock
@@ -48,6 +49,26 @@ def test_bus_creation(self):
         self.assertTrue(canlib.canOpenChannel.called)
         self.assertTrue(canlib.canBusOn.called)
 
+    def test_bus_creation_illegal_channel_name(self):
+        # Test if the bus constructor is able to deal with non-ASCII characters
+        def canGetChannelDataMock(
+            channel: ctypes.c_int,
+            param: ctypes.c_int,
+            buf: ctypes.c_void_p,
+            bufsize: ctypes.c_size_t,
+        ):
+            if param == constants.canCHANNELDATA_DEVDESCR_ASCII:
+                buf_char_ptr = ctypes.cast(buf, ctypes.POINTER(ctypes.c_char))
+                for i, char in enumerate(b"hello\x7a\xcb"):
+                    buf_char_ptr[i] = char
+
+        canlib.canGetChannelData = canGetChannelDataMock
+        bus = can.Bus(channel=0, interface="kvaser")
+
+        self.assertTrue(bus.channel_info.startswith("hello"))
+
+        bus.shutdown()
+
     def test_bus_shutdown(self):
         self.bus.shutdown()
         self.assertTrue(canlib.canBusOff.called)