Skip to content

chore: adopt shared conf-renovate preset (v1.2.1)#15

Closed
gofreight-jackyeh wants to merge 1 commit into
mainfrom
feat/adopt-conf-renovate-preset
Closed

chore: adopt shared conf-renovate preset (v1.2.1)#15
gofreight-jackyeh wants to merge 1 commit into
mainfrom
feat/adopt-conf-renovate-preset

Conversation

@gofreight-jackyeh
Copy link
Copy Markdown
Contributor

Summary

Switches this repo onto the org-shared Renovate preset hardcoretech/conf-renovate pinned at v1.2.1. Part of the fleet rollout following the pilots gf-admin-console#182 (merged) and svc-thor#160.

The local config simplifies to the baseline:

{
  $schema: "https://docs.renovatebot.com/renovate-schema.json",
  extends: [
    "github>hardcoretech/conf-renovate#v1.2.1",
    ":preserveSemverRanges",
  ],
  labels: ["dependencies"],
}

What was dropped from the previous renovate.json (merge mode)

Dropped Replaced by
extends: ["config:recommended"] Preset default.json5 extends config:best-practices (stricter superset).
FIS-17871 GHA-hardening packageRule (pinDigests + minimumReleaseAge: "3 days") Preset security.json5 (locked). The previous local rule lacked a matchUpdateTypes filter and would silently override the locked major-isolation policy — same blocker the reviewer caught on gf-admin-console#182 round 1.
groupName: "GitHub Actions" Preset grouping-gha.json5 provides gha-non-major + isolated gha-major.

renovate.jsonrenovate.json5 rename (old file deleted in same commit; renovate.json has higher Renovate lookup precedence).

What the preset provides (inherited baseline)

  • config:best-practices + dependency dashboard.
  • SHA-pin GHA + 3-day release-age soak + OSV alerts (locked).
  • Per-ecosystem PR grouping with major-update isolation.
  • Datastore version pinning (mysql / rabbitmq / valkey on docker+helm).
  • Built-in self-bump customManager — the next preset release auto-PRs a bump of #v1.2.1 here without any local config.

Validation gate

Adds the renovate-config-validator pre-commit hook (pinned to renovatebot/pre-commit-hooks@43.150.0) to .pre-commit-config.yaml. The existing CI pipeline already runs pre-commit run, so the same gate executes on PR + push without a new workflow file.

Verification

  • renovate-config-validator --strict --no-global renovate.json5 passes locally (Node 24 + renovate@43, LOG_LEVEL=warn, exit 0).
  • After merge: Renovate dashboard onboards the new config cleanly.
  • First scheduled run produces PRs under preset group names (e.g. gha-non-major, plus ecosystem groups as applicable).
  • Next conf-renovate release auto-PRs a bump of #v1.2.1#v<next>.

Rollback

Revert this branch — restores renovate.json exactly as it was before.

Switches this repo onto the org-shared Renovate preset
`hardcoretech/conf-renovate` pinned at v1.2.1. Mirrors the
gf-admin-console pilot (#182, merged) and the svc-thor adoption (#160).

What changed vs. the prior `renovate.json`:
- File renamed `renovate.json` → `renovate.json5` so override rationale
  can live as inline comments. The old file is deleted in this commit
  (renovate.json has higher precedence than .json5 in Renovate's lookup).
- Dropped `extends: ["config:recommended"]` — preset already extends
  `config:best-practices` (a stricter superset).
- Dropped the FIS-17871 GHA-hardening packageRule — same SHA-pin +
  3-day soak policy is now provided by the preset's `security` atomic
  preset (locked). The previous local form lacked a `matchUpdateTypes`
  filter and would silently override the locked major-isolation policy.

Validation gate: adds the `renovate-config-validator` pre-commit hook to `.pre-commit-config.yaml` (existing CI runs `pre-commit run`).
@gofreight-jackyeh gofreight-jackyeh requested a review from a team as a code owner May 18, 2026 11:45
@github-actions
Copy link
Copy Markdown

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit a7feea5.

@gofreight-jackyeh
Copy link
Copy Markdown
Contributor Author

Superseded by #16. The previous form (extends: ["github>hardcoretech/conf-renovate#vX.Y.Z"]) doesn't resolve on this public repo because the referenced preset repo isn't reachable from the public-scoped Renovate run. #16 replaces it with a self-contained config that has the same effective policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant