Skip to content

Commit 4aaace2

Browse files
jhovoldgregkh
authored andcommitted
mmc: vub3000: fix control-request direction
commit 3c0bb31 upstream. The direction of the pipe argument must match the request-type direction bit or control requests may fail depending on the host-controller-driver implementation. Fix the SET_ROM_WAIT_STATES request which erroneously used usb_rcvctrlpipe(). Fixes: 88095e7 ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver") Cc: stable@vger.kernel.org # 3.0 Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20210521133026.17296-1-johan@kernel.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5712b82 commit 4aaace2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/mmc/host/vub300.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2286,7 +2286,7 @@ static int vub300_probe(struct usb_interface *interface,
22862286
if (retval < 0)
22872287
goto error5;
22882288
retval =
2289-
usb_control_msg(vub300->udev, usb_rcvctrlpipe(vub300->udev, 0),
2289+
usb_control_msg(vub300->udev, usb_sndctrlpipe(vub300->udev, 0),
22902290
SET_ROM_WAIT_STATES,
22912291
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
22922292
firmware_rom_wait_states, 0x0000, NULL, 0, HZ);

0 commit comments

Comments
 (0)