Skip to content

Commit 1197ab1

Browse files
committed
Responded to copilot review
1 parent 0e212a9 commit 1197ab1

2 files changed

Lines changed: 13 additions & 12 deletions

File tree

.github/copilot-instructions.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -223,17 +223,17 @@ python -m unittest tests.models.test_hed_string.TestHedStrings.test_constructor
223223

224224
### CI/CD pipeline (`.github/workflows/`)
225225

226-
| Workflow | File | Trigger | Purpose |
227-
|---|---|---|---|
228-
| Tests | `ci.yaml` | push/PR to main | Python 3.10–3.13 on Ubuntu |
229-
| Coverage | `ci_cov.yaml` | push/PR to main | Coverage report |
230-
| Windows tests | `ci_windows.yaml` | push/PR to main | Windows compatibility |
231-
| Ruff | `ruff.yaml` | push/PR to main | Lint + format check |
232-
| Typos | `typos.yaml` | push/PR to main | Spelling check |
233-
| Spec tests | `spec_tests.yaml` | push/PR to main | HED specification compliance |
234-
| Docs | `docs.yaml` | push/PR to main | Sphinx build |
235-
| Notebooks | `notebook_tests.yaml` | push/PR to main | Jupyter notebook execution |
236-
| Links | `links.yaml` | scheduled | Dead-link checker (lychee) |
226+
| Workflow | File | Trigger | Purpose |
227+
| ------------- | --------------------- | --------------------------- | ----------------------------------------------------------------------- |
228+
| Tests | `ci.yaml` | push/PR to any branch | Python 3.10–3.14 on Ubuntu (main branch); 3.10 & 3.13 on other branches |
229+
| Coverage | `ci_cov.yaml` | push to main only | Coverage report, Python 3.10 |
230+
| Windows tests | `ci_windows.yaml` | push/PR to main | Python 3.10–3.12 on Windows |
231+
| Ruff | `ruff.yaml` | push/PR to main | Lint + format check |
232+
| Typos | `typos.yaml` | push/PR to main | Spelling check |
233+
| Spec tests | `spec_tests.yaml` | push/PR to any branch | HED specification compliance, Python 3.10 |
234+
| Docs | `docs.yaml` | push/PR to main | Sphinx build |
235+
| Notebooks | `notebook_tests.yaml` | push/PR to main | Jupyter notebook execution |
236+
| Links | `links.yaml` | scheduled + manual dispatch | Dead-link checker (lychee) |
237237

238238
To replicate CI locally, run `ruff check`, `ruff format --check`, `typos`, and `python -m unittest discover tests -v` before pushing.
239239

hed/schema/schema_io/hed_id_util.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ def _get_hedid_range(schema_name, df_key):
3030
3131
Parameters:
3232
schema_name(str): The known schema name with an assigned id range.
33-
df_key(str): The dataframe range type we're interested in. A key from constants.DF_SUFFIXES.
33+
df_key(str): The dataframe section type. Must be a key in object_type_id_offset
34+
(STRUCT_KEY is not accepted and will raise NotImplementedError).
3435
3536
Returns:
3637
set: A set of all id's in the requested range.

0 commit comments

Comments
 (0)