Skip to content

[BUGFIX] Fix PHP warnings for undefined array key#90

Open
theLine wants to merge 1 commit into
helhum:mainfrom
theLine:main
Open

[BUGFIX] Fix PHP warnings for undefined array key#90
theLine wants to merge 1 commit into
helhum:mainfrom
theLine:main

Conversation

@theLine

@theLine theLine commented Feb 23, 2023

Copy link
Copy Markdown

No description provided.

Comment thread Classes/Mvc/RequestBuilder.php Outdated
Comment thread Classes/Uri/TyposcriptRenderingUri.php

@helhum helhum left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge if you remove the array_key_exists

@helhum

helhum commented Feb 27, 2023

Copy link
Copy Markdown
Owner

Not sure what the failing tests mean, though :-/

@mediaessenz

mediaessenz commented Apr 8, 2023

Copy link
Copy Markdown

All failed tests calling urls containing the language slug "da/".

I can't find any definition of this slug inside the test data. Maybe this is the reason, why they fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants