Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Commit 4325a29

Browse files
jyoung488jyoung488
authored
Merge pull request #46 from HelloFax/boolean_formatting_fixes
Only convert bools to strings where appropriate
2 parents bff95da + 520b6d6 commit 4325a29

2 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎hellosign_sdk/hsclient.py‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class HSClient(object):
3636
3737
'''
3838

39-
version = '3.8.5' # SDK version
39+
version = '3.8.7' # SDK version
4040
API_VERSION = 'v3' # API version
4141
API_URL = ''
4242

@@ -111,12 +111,12 @@ def __str__(self):
111111
def _init_endpoints(self):
112112

113113
API_PRODUCTION_URL = "https://api.hellosign.com"
114-
API_DEV_URL = "https://www.dev-hellosign.com/apiapp_dev.php"
115-
API_STAGING_URL = "https://staging.hellosign.com/apiapp.php"
114+
API_DEV_URL = "https://api.dev-hellosign.com"
115+
API_STAGING_URL = "https://api.staging-hellosign.com"
116116

117-
WEB_PRODUCTION_URL = "https://www.hellosign.com"
118-
WEB_DEV_URL = "https://www.dev-hellosign.com/webapp_dev.php"
119-
WEB_STAGING_URL = "https://staging.hellosign.com/webapp_dev.php"
117+
WEB_PRODUCTION_URL = "https://app.hellosign.com"
118+
WEB_DEV_URL = "https://app.dev-hellosign.com"
119+
WEB_STAGING_URL = "https://app.staging-hellosign.com"
120120

121121
if self.env == "production":
122122
self.API_URL = API_PRODUCTION_URL + '/' + self.API_VERSION
@@ -395,7 +395,7 @@ def send_signature_request(self, test_mode=False, files=None, file_urls=None, ti
395395
)
396396

397397
params = {
398-
'test_mode': self._boolean(test_mode),
398+
'test_mode': test_mode,
399399
'files': files,
400400
'file_urls': file_urls,
401401
'title': title,
@@ -405,10 +405,10 @@ def send_signature_request(self, test_mode=False, files=None, file_urls=None, ti
405405
'signers': signers,
406406
'cc_email_addresses': cc_email_addresses,
407407
'form_fields_per_document': form_fields_per_document,
408-
'use_text_tags': self._boolean(use_text_tags),
409-
'hide_text_tags': self._boolean(hide_text_tags),
408+
'use_text_tags': use_text_tags,
409+
'hide_text_tags': hide_text_tags,
410410
'metadata': metadata,
411-
'allow_decline': self._boolean(allow_decline)
411+
'allow_decline': allow_decline
412412
}
413413

414414
if ux_version is not None:
@@ -472,7 +472,7 @@ def send_signature_request_with_template(self, test_mode=False, template_id=None
472472
)
473473

474474
params = {
475-
'test_mode': self._boolean(test_mode),
475+
'test_mode': test_mode,
476476
'template_id': template_id,
477477
'template_ids': template_ids,
478478
'title': title,
@@ -597,7 +597,7 @@ def send_signature_request_embedded(self, test_mode=False, client_id=None, files
597597
)
598598

599599
params = {
600-
'test_mode': self._boolean(test_mode),
600+
'test_mode': test_mode,
601601
'client_id': client_id,
602602
'files': files,
603603
'file_urls': file_urls,
@@ -608,8 +608,8 @@ def send_signature_request_embedded(self, test_mode=False, client_id=None, files
608608
'signers': signers,
609609
'cc_email_addresses': cc_email_addresses,
610610
'form_fields_per_document': form_fields_per_document,
611-
'use_text_tags': self._boolean(use_text_tags),
612-
'hide_text_tags': self._boolean(hide_text_tags),
611+
'use_text_tags': use_text_tags,
612+
'hide_text_tags': hide_text_tags,
613613
'metadata': metadata,
614614
'allow_decline': allow_decline
615615
}
@@ -679,7 +679,7 @@ def send_signature_request_embedded_with_template(self, test_mode=False, client_
679679
)
680680

681681
params = {
682-
'test_mode': self._boolean(test_mode),
682+
'test_mode': test_mode,
683683
'client_id': client_id,
684684
'template_id': template_id,
685685
'template_ids': template_ids,
@@ -852,7 +852,7 @@ def create_embedded_template_draft(self, client_id, signer_roles, test_mode=Fals
852852
853853
'''
854854
params = {
855-
'test_mode': self._boolean(test_mode),
855+
'test_mode': test_mode,
856856
'client_id': client_id,
857857
'files': files,
858858
'file_urls': file_urls,
@@ -1056,7 +1056,7 @@ def create_unclaimed_draft(self, test_mode=False, files=None, file_urls=None, dr
10561056
)
10571057

10581058
params = {
1059-
'test_mode': self._boolean(test_mode),
1059+
'test_mode': test_mode,
10601060
'files': files,
10611061
'file_urls': file_urls,
10621062
'draft_type': draft_type,
@@ -1068,7 +1068,7 @@ def create_unclaimed_draft(self, test_mode=False, files=None, file_urls=None, dr
10681068
'form_fields_per_document': form_fields_per_document,
10691069
'metadata': metadata,
10701070
'use_preexisting_fields': use_preexisting_fields,
1071-
'allow_decline': self._boolean(allow_decline)
1071+
'allow_decline': allow_decline
10721072
}
10731073

10741074
return self._create_unclaimed_draft(**params)
@@ -1132,10 +1132,10 @@ def create_embedded_unclaimed_draft(self, test_mode=False, client_id=None, is_fo
11321132
)
11331133

11341134
params = {
1135-
'test_mode': self._boolean(test_mode),
1135+
'test_mode': test_mode,
11361136
'client_id': client_id,
11371137
'requester_email_address': requester_email_address,
1138-
'is_for_embedded_signing': self._boolean(is_for_embedded_signing),
1138+
'is_for_embedded_signing': is_for_embedded_signing,
11391139
'files': files,
11401140
'file_urls': file_urls,
11411141
'draft_type': draft_type,
@@ -1148,7 +1148,7 @@ def create_embedded_unclaimed_draft(self, test_mode=False, client_id=None, is_fo
11481148
'form_fields_per_document': form_fields_per_document,
11491149
'metadata': metadata,
11501150
'use_preexisting_fields': use_preexisting_fields,
1151-
'allow_decline': self._boolean(allow_decline)
1151+
'allow_decline': allow_decline
11521152
}
11531153

11541154
return self._create_unclaimed_draft(**params)
@@ -1205,7 +1205,7 @@ def create_embedded_unclaimed_draft_with_template(self, test_mode=False, client_
12051205
)
12061206

12071207
params = {
1208-
'test_mode': self._boolean(test_mode),
1208+
'test_mode': test_mode,
12091209
'client_id': client_id,
12101210
'is_for_embedded_signing': is_for_embedded_signing,
12111211
'template_id': template_id,
@@ -1220,7 +1220,7 @@ def create_embedded_unclaimed_draft_with_template(self, test_mode=False, client_
12201220
'ccs': ccs,
12211221
'custom_fields': custom_fields,
12221222
'metadata': metadata,
1223-
'allow_decline': self._boolean(allow_decline)
1223+
'allow_decline': allow_decline
12241224
}
12251225

12261226
return self._create_embedded_unclaimed_draft_with_template(**params)
@@ -1626,7 +1626,7 @@ def _create_unclaimed_draft(self, test_mode=False, client_id=None, is_for_embedd
16261626
"message": message,
16271627
"signing_redirect_url": signing_redirect_url,
16281628
"form_fields_per_document": form_fields_per_document,
1629-
"use_preexisting_fields": use_preexisting_fields,
1629+
"use_preexisting_fields": self._boolean(use_preexisting_fields),
16301630
"allow_decline": self._boolean(allow_decline)
16311631
}
16321632

@@ -1745,7 +1745,7 @@ def _create_embedded_template_draft(self, client_id, signer_roles, test_mode=Fal
17451745
'title': title,
17461746
'subject': subject,
17471747
'message': message,
1748-
'use_preexisting_fields': use_preexisting_fields
1748+
'use_preexisting_fields': self._boolean(use_preexisting_fields)
17491749
}
17501750

17511751
# Prep files
@@ -1787,7 +1787,7 @@ def _create_embedded_unclaimed_draft_with_template(self, test_mode=False, client
17871787
payload = {
17881788
"test_mode": self._boolean(test_mode),
17891789
"client_id": client_id,
1790-
"is_for_embedded_signing": is_for_embedded_signing,
1790+
"is_for_embedded_signing": self._boolean(is_for_embedded_signing),
17911791
"template_id": template_id,
17921792
"requester_email_address": requester_email_address,
17931793
"title": title,

‎setup.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def readme():
1111

1212
setup(
1313
name='hellosign-python-sdk',
14-
version='3.8.6',
14+
version='3.8.7',
1515
description="A Python wrapper for the HelloSign API (http://www.hellosign.com/api)",
1616
long_description=readme(),
1717
classifiers=[

0 commit comments

Comments
 (0)