You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[idea] Let tab_bar_right status wrap to its own row instead of hiding when tabs need the space
#5461
I use ui.tab_bar_right for a small macOS status: battery, CPU, memory and network, about 40 columns. The status shares the row with the tabs, so every column it uses is one the tabs lose. With a few tabs open in a narrower window, the tab labels get squeezed. Once fewer than 17 columns are left for tabs, the whole status disappears (tabs.rs:237-255 (
let reserved = tab_bar_status_area(snapshot, area)
.map(|status| status.width.saturating_add(1))
.unwrap_or(0);
Rect{
width: area.width.saturating_sub(reserved),
..area
}
}
)). So I end up choosing between readable tab names and the status, and which one I get changes as I resize the window or open tabs.
requested change
An opt-in tab bar setting, for example ui.tab_bar_right_placement:
inline: today's behaviour, and the default
own_row: always render the status right-aligned on a second line of the tab bar
auto: inline when it fits, a second line instead of hiding when it doesn't
This keeps the status part of the tab bar: it follows tab_bar_position, uses the same entries and config, and isn't a separate status bar.
why you want this
#1629 was closed as covered by tab_bar_right, and for content it is covered: the entries work well. What's missing is room for them. #1747 asks for a full-width row for similar reasons. With this setting, the tabs and the status would stop competing for the same columns, at the cost of one extra row for people who opt in.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
idea / problem
I use ui.tab_bar_right for a small macOS status: battery, CPU, memory and network, about 40 columns. The status shares the row with the tabs, so every column it uses is one the tabs lose. With a few tabs open in a narrower window, the tab labels get squeezed. Once fewer than 17 columns are left for tabs, the whole status disappears (tabs.rs:237-255 (
herdr/src/client/shell/tabs.rs
Lines 237 to 255 in 2ecf19a
requested change
An opt-in tab bar setting, for example ui.tab_bar_right_placement:
This keeps the status part of the tab bar: it follows tab_bar_position, uses the same entries and config, and isn't a separate status bar.
why you want this
#1629 was closed as covered by tab_bar_right, and for content it is covered: the entries work well. What's missing is room for them. #1747 asks for a full-width row for similar reasons. With this setting, the tabs and the status would stop competing for the same columns, at the cost of one extra row for people who opt in.
All reactions