Skip to content

Commit 4d3cfe6

Browse files
committed
Fix warnings
1 parent 939afdb commit 4d3cfe6

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

apps/codebattle/lib/codebattle/external_platform.ex

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ defmodule Codebattle.ExternalPlatform do
139139
end
140140
end
141141

142+
def poll_invite_status(_), do: {:error, :invalid_operation_id}
143+
142144
defp do_poll_invite_status(operation_id) do
143145
url = "#{external_platform_service_url()}#{@operations_path}:#{operation_id}"
144146

@@ -177,8 +179,6 @@ defmodule Codebattle.ExternalPlatform do
177179
end
178180
end
179181

180-
def poll_invite_status(_), do: {:error, :invalid_operation_id}
181-
182182
@doc """
183183
Fetches an organization invite by its ID.
184184
Hits the local sc proxy: GET /v1/invites/{invite_id}
@@ -193,6 +193,8 @@ defmodule Codebattle.ExternalPlatform do
193193
end
194194
end
195195

196+
def get_invite(_), do: {:error, :invalid_invite_id}
197+
196198
defp do_get_invite(invite_id) do
197199
url = "#{external_platform_service_url()}/v1/invites/#{invite_id}"
198200

@@ -230,8 +232,6 @@ defmodule Codebattle.ExternalPlatform do
230232
end
231233
end
232234

233-
def get_invite(_), do: {:error, :invalid_invite_id}
234-
235235
@doc """
236236
Creates a repository in the target organization from a template repository.
237237
POST /orgs/{org_slug}/repos
@@ -385,6 +385,8 @@ defmodule Codebattle.ExternalPlatform do
385385
end
386386
end
387387

388+
def upsert_secret(_, _, _, _, _), do: {:error, :invalid_secret_request}
389+
388390
defp do_upsert_secret(org_slug, repo_slug, key, value, opts) do
389391
body = %{value: value}
390392

@@ -429,8 +431,6 @@ defmodule Codebattle.ExternalPlatform do
429431
end
430432
end
431433

432-
def upsert_secret(_, _, _, _, _), do: {:error, :invalid_secret_request}
433-
434434
defp do_get_user_by_login(login) do
435435
url = external_platform_service_url() <> @lookup_path
436436

apps/codebattle/lib/codebattle_web/channels/group_tournament_channel.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ defmodule CodebattleWeb.GroupTournamentChannel do
134134
}
135135
end
136136

137-
defp serialize_invite_reply(user, group_tournament, invite, platform_error \\ nil) do
137+
defp serialize_invite_reply(user, group_tournament, invite, platform_error) do
138138
external_setup = maybe_ensure_external_setup(user, group_tournament, invite)
139139

140140
%{

0 commit comments

Comments
 (0)