Code refactor

- move newProperties to a function and call it only when needed
- added more mapped attributes
- updated tsconfig

Author: high1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "solid-jsx",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "",
   "source": "src/jsx-runtime.ts",
   "main": "./dist/jsx-runtime.js",

src/jsx-runtime.ts

@@ -3,20 +3,23 @@ import { Dynamic } from 'solid-js/web';
 
 export const Fragment = (properties: PropsWithChildren): JSX.Element => properties.children;
 
-export const jsx = (
-  type: string | ((properties_: PropsWithChildren) => JSX.Element),
-  properties: Record<string, unknown> & { children: JSX.Element }
-): JSX.Element => {
+const getNewProperties = (
+  properties: Record<string, unknown> & { children?: JSX.Element }
+): PropsWithChildren => {
   const newProperties: Record<string, unknown> = {};
-
   for (const key of Object.keys(properties)) newProperties[jsxKeyToSolid(key)] = properties[key];
+  return newProperties;
+};
 
-  return typeof type === 'function'
+export const jsx = (
+  type: string | ((properties_: PropsWithChildren) => JSX.Element),
+  properties: PropsWithChildren
+): JSX.Element =>
+  typeof type === 'function'
     ? type.name === 'Fragment'
       ? properties.children
-      : type(newProperties)
-    : createComponent(Dynamic, mergeProps(newProperties, { component: type }));
-};
+      : type(getNewProperties(properties))
+    : createComponent(Dynamic, mergeProps(getNewProperties(properties), { component: type }));
 
 // For the moment we do not distinguish static children from dynamic ones
 export const jsxs = jsx;
@@ -34,6 +37,11 @@ const MAPPED_ATTRIBUTES = new Map([
   ['autoFocus', 'autofocus'],
   ['contentEditable', 'contenteditable'],
   ['noValidate', 'novalidate'],
+  ['isMap', 'ismap'],
+  ['playsInline', 'playsinline'],
+  ['allowFullScreen', 'allowfullscreen'],
+  ['formNoValidate', 'formnovalidate'],
+  ['noModule', 'nomodule'],
 ]);
 
 const jsxKeyToSolid = (key: string): string =>

tsconfig.json

@@ -11,7 +11,7 @@
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
 
     /* Language and Environment */
-    "target": "es2016" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
+    "target": "es6" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,
     // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     "jsx": "preserve" /* Specify what JSX code is generated. */,
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
@@ -74,7 +74,7 @@
     "forceConsistentCasingInFileNames": true /* Ensure that casing is correct in imports. */,
 
     /* Type Checking */
-    "strict": true /* Enable all strict type-checking options. */,
+    "strict": true /* Enable all strict type-checking options. */
     // "noImplicitAny": true,                            /* Enable error reporting for expressions and declarations with an implied `any` type.. */
     // "strictNullChecks": true,                         /* When type checking, take into account `null` and `undefined`. */
     // "strictFunctionTypes": true,                      /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */
@@ -96,6 +96,6 @@
 
     /* Completeness */
     // "skipDefaultLibCheck": true,                      /* Skip type checking .d.ts files that are included with TypeScript. */
-    "skipLibCheck": true /* Skip type checking all .d.ts files. */
+    // "skipLibCheck": true                              /* Skip type checking all .d.ts files. */
   }
 }