chore: bit hacky health handler

Author: MarcStdt

cmd/serve.go

@@ -161,6 +161,7 @@ to interact and monitor the Scroll Application`,
 					if currentScroll.CanColdStart() {
 
 						for {
+							healthHandler.Started = false
 							logger.Log().Info("Starting coldstarter")
 							finish := coldStarter.Start(ctx)
 							executedPort := <-finish
@@ -171,7 +172,7 @@ to interact and monitor the Scroll Application`,
 
 							logger.Log().Info("Coldstarter done, starting scroll")
 
-							startup(scrollService, processLauncher, queueManager, portService, coldStarter, cwd, doneChan)
+							startup(scrollService, processLauncher, queueManager, portService, coldStarter, healthHandler, cwd, doneChan)
 
 							portService.ResetOpenPorts()
 
@@ -211,10 +212,10 @@ to interact and monitor the Scroll Application`,
 						}
 					} else {
 						logger.Log().Warn("No ports to start, skipping coldstarter")
-						startup(scrollService, processLauncher, queueManager, portService, coldStarter, cwd, doneChan)
+						startup(scrollService, processLauncher, queueManager, portService, coldStarter, healthHandler, cwd, doneChan)
 					}
 				} else {
-					startup(scrollService, processLauncher, queueManager, portService, coldStarter, cwd, doneChan)
+					startup(scrollService, processLauncher, queueManager, portService, coldStarter, healthHandler, cwd, doneChan)
 				}
 
 			}()
@@ -264,7 +265,9 @@ func init() {
 	ServeCommand.Flags().UintVarP(&maxStartupHealthCheckTimeout, "max-health-check-startup-timeount", "", 0, "Sets the max amount of time the health check is allowed to take on startup. If the value is 0, there will be no timeout. This is useful to prevent the health check from blocking the startup of the daemon fully.")
 }
 
-func startup(scrollService *services.ScrollService, processLauncher *services.ProcedureLauncher, queueManager *services.QueueManager, portSerivce *services.PortMonitor, coldStarter *services.ColdStarter, cwd string, doneChan chan error) {
+func startup(scrollService *services.ScrollService, processLauncher *services.ProcedureLauncher, queueManager *services.QueueManager, portSerivce *services.PortMonitor, coldStarter *services.ColdStarter, healthHandler *handler.HealthHandler, cwd string, doneChan chan error) {
+
+	healthHandler.Started = true
 
 	currentScroll := scrollService.GetCurrent()
 

internal/handler/health_handler.go

@@ -10,6 +10,7 @@ import (
 type HealthHandler struct {
 	portService ports.PortServiceInterface
 	timeoutDone bool
+	Started     bool
 }
 
 func NewHealthHandler(
@@ -20,6 +21,7 @@ func NewHealthHandler(
 	h := &HealthHandler{
 		portService,
 		false,
+		false,
 	}
 
 	// if timeoutSec == 0, we want at some point to not show a bad health status
@@ -48,7 +50,9 @@ func (p *HealthHandler) Health(c *fiber.Ctx) error {
 		return c.SendString("Manditory ports are not open")
 
 	}
-
+	if !p.Started {
+		return c.SendString("idle")
+	}
 	return c.SendString("ok")
 }