From 17ae7486123aac78bb4abc543ea233fc33f369ba Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 18 Jul 2026 07:17:27 +0000 Subject: [PATCH 1/3] Initial plan From d721896e87930f1dfc9e25978e432f85ae79537e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 18 Jul 2026 07:19:21 +0000 Subject: [PATCH 2/3] Fix cpp/overrunning-write alert: use snprintf instead of sprintf in plot.cc --- src/plot.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plot.cc b/src/plot.cc index 31b90f6..edc3170 100644 --- a/src/plot.cc +++ b/src/plot.cc @@ -138,9 +138,9 @@ namespace int omag=int(log10(x)); int lead=x*pow(10,-omag); #if defined(PANGO) && !defined(_WIN32) - sprintf(label,"%d×10%d",lead,omag); + snprintf(label,sizeof(label),"%d×10%d",lead,omag); #else - sprintf(label,"%dE%d",lead,omag); + snprintf(label,sizeof(label),"%dE%d",lead,omag); #endif } return label; From d7d838b7c93691b82c1d1e8ee6f5663c3a5dea53 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 18 Jul 2026 07:54:47 +0000 Subject: [PATCH 3/3] Increase label buffer from 30 to 64 bytes to prevent overflow --- src/plot.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plot.cc b/src/plot.cc index edc3170..aa95fcd 100644 --- a/src/plot.cc +++ b/src/plot.cc @@ -123,7 +123,7 @@ namespace // magnitude if log string logAxisLabel(double x) { - char label[30]; + char label[64]; if (x<=0) return ""; // -ve values meaningless if (x>=0.01 && x<1) { @@ -138,9 +138,9 @@ namespace int omag=int(log10(x)); int lead=x*pow(10,-omag); #if defined(PANGO) && !defined(_WIN32) - snprintf(label,sizeof(label),"%d×10%d",lead,omag); + sprintf(label,"%d×10%d",lead,omag); #else - snprintf(label,sizeof(label),"%dE%d",lead,omag); + sprintf(label,"%dE%d",lead,omag); #endif } return label;