Skip to content

Commit 7f5bf12

Browse files
committed
Add Contributing section to README
1 parent f7630ce commit 7f5bf12

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ The existing Walmart client libraries for PHP are either incomplete, outdated, o
6161
* [Marketplace](#marketplace)
6262
* [1P Supplier](#1p-supplier)
6363
* [Content Provider](#content-provider)
64+
* [Contributing](#contributing)
6465

6566

6667
## Getting Started
@@ -267,3 +268,14 @@ _Note_: The 1P Supplier APIs are currently only available in the US.
267268
_Note_: The Content Provider APIs are currently only available in the US.
268269

269270
* [Feeds API](https://github.com/highsidelabs/walmart-api-php/blob/main/docs/Apis/CP/US/FeedsApi.md): `Walmart::contentProvider($config)->feeds()`
271+
272+
273+
## Contributing
274+
275+
Thanks for making it all the way down here! We welcome your contributions...the open-source world runs on people like you.
276+
277+
## Pull requests
278+
279+
Please ask (via an issue) before submitting a pull request for any significant feature work. It sucks to put a lot of effort into something only to have it rejected for reasons other than the quality of your code. (_Author's note: don't ask me how I know._) That said, we're open to contributions from anyone, and we'll do our best to get your code merged. Please be patient – we're not ignoring you, but it might take us some time to get to your PR.
280+
281+
Before submitting a PR, please format your code with `composer lint`.

utils/helpers.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ function libVersion(): string
154154
* Merge two arrays recursively, overwriting keys in the first array with keys from the second array.
155155
* Poached from https://www.php.net/manual/en/function.array-merge-recursive.php#92195
156156
*
157-
* @param array $array1
158-
* @param array $array2
157+
* @param array $array1
158+
* @param array $array2
159159
* @return array
160160
*/
161161
function array_merge_recursive_distinct(array &$array1, array &$array2): array

0 commit comments

Comments
 (0)