Seems like I don't need to build libchewing into static library, the shared library form just works

hiroshiyui · hiroshiyui · commit da59be2ab77e · 2024-05-28T10:46:57.000+08:00
Signed-off-by: Hui-Hong You &lt;hiroshi@ghostsinthelab.org&gt;
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -37,7 +37,7 @@ android {
             cmake {
                 cFlags("-Wno-unused-function", "-Wno-unused-but-set-variable")
                 cppFlags += ""
-                targets("libchewing", "${projectName}")
+                targets("${projectName}")
             }
         }
 
@@ -79,7 +79,7 @@ android {
 
     tasks.register<Exec>("prepareChewing") {
         workingDir(chewingLibraryPath)
-        commandLine("cmake", "--preset", "rust-release", "-DBUILD_SHARED_LIBS=OFF", ".")
+        commandLine("cmake", "--preset", "rust-release")
     }
 
     val chewingDataFiles =
diff --git a/app/src/main/cpp/CMakeLists.txt b/app/src/main/cpp/CMakeLists.txt
@@ -16,7 +16,6 @@ project("libchewing_android_app_module" LANGUAGES C CXX)
 SET(BUILD_INFO true)
 SET(WITH_RUST true)
 SET(WITH_SQLITE3 false)
-SET(BUILD_SHARED_LIBS OFF)
 add_subdirectory(${CMAKE_SOURCE_DIR}/libs/libchewing EXCLUDE_FROM_ALL)
 
 # Creates and names a library, sets it as either STATIC

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ android {`
`37`	`37`	`cmake {`
`38`	`38`	`cFlags("-Wno-unused-function", "-Wno-unused-but-set-variable")`
`39`	`39`	`cppFlags += ""`
`40`		`- targets("libchewing", "${projectName}")`
	`40`	`+ targets("${projectName}")`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`
`@@ -79,7 +79,7 @@ android {`
`79`	`79`
`80`	`80`	`tasks.register<Exec>("prepareChewing") {`
`81`	`81`	`workingDir(chewingLibraryPath)`
`82`		`- commandLine("cmake", "--preset", "rust-release", "-DBUILD_SHARED_LIBS=OFF", ".")`
	`82`	`+ commandLine("cmake", "--preset", "rust-release")`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`val chewingDataFiles =`