fix: support boolean query params in api codegen

Author: mworzala

api/v4Internal/server.gen.go

@@ -190,6 +190,24 @@ func writeQueryParam(buf *bytes.Buffer, p *Param) {
 			fmt.Fprintf(buf, "\t\t}\n")
 			fmt.Fprintf(buf, "\t}\n")
 		}
+	case "bool":
+		if p.Required {
+			fmt.Fprintf(buf, "\tif v, err := strconv.ParseBool(r.URL.Query().Get(%q)); err != nil {\n", p.Name)
+			fmt.Fprintf(buf, "\t\truntime.WriteBadRequest(w, %q)\n", "invalid query parameter: "+p.Name)
+			fmt.Fprintf(buf, "\t\treturn\n")
+			fmt.Fprintf(buf, "\t} else {\n")
+			fmt.Fprintf(buf, "\t\treq.%s = v\n", p.GoName)
+			fmt.Fprintf(buf, "\t}\n")
+		} else {
+			fmt.Fprintf(buf, "\tif qs := r.URL.Query().Get(%q); qs != \"\" {\n", p.Name)
+			fmt.Fprintf(buf, "\t\tif v, err := strconv.ParseBool(qs); err != nil {\n")
+			fmt.Fprintf(buf, "\t\t\truntime.WriteBadRequest(w, %q)\n", "invalid query parameter: "+p.Name)
+			fmt.Fprintf(buf, "\t\t\treturn\n")
+			fmt.Fprintf(buf, "\t\t} else {\n")
+			fmt.Fprintf(buf, "\t\t\treq.%s = v\n", p.GoName)
+			fmt.Fprintf(buf, "\t\t}\n")
+			fmt.Fprintf(buf, "\t}\n")
+		}
 	}
 }
 

pkg/ox/gen/codegen.go

@@ -407,3 +407,48 @@ func TestGenerateServer_BaseURLPlacement(t *testing.T) {
 	require.NotContains(t, src, `params.BaseURL+"GET `, "BaseURL should not come before HTTP method")
 	require.NotContains(t, src, `params.BaseURL+"POST `, "BaseURL should not come before HTTP method")
 }
+
+func TestGenerateServer_BooleanQueryParams(t *testing.T) {
+	api := &API{
+		PackageName: "v4",
+		StructName:  "Server",
+		ModulePath:  "github.com/example/app",
+		Endpoints: []Endpoint{
+			{
+				Name:        "SearchItems",
+				Method:      "GET",
+				Path:        "/items",
+				RequestType: "SearchItemsRequest",
+				Params: []Param{
+					{Name: "active", GoName: "Active", GoType: "bool", Location: "query", Required: true},
+					{Name: "verified", GoName: "Verified", GoType: "bool", Location: "query", Required: false},
+				},
+				Response: Response{StatusCode: 200, GoType: "[]Item"},
+			},
+		},
+	}
+
+	code, err := GenerateServer(api)
+	require.NoError(t, err)
+
+	src := string(code)
+
+	// Verify it parses as valid Go
+	fset := token.NewFileSet()
+	_, err = parser.ParseFile(fset, "server.gen.go", src, 0)
+	require.NoError(t, err, "generated code should be valid Go")
+
+	// Check required boolean parameter handling
+	require.Contains(t, src, `strconv.ParseBool(r.URL.Query().Get("active"))`)
+	require.Contains(t, src, `req.Active = v`)
+	require.Contains(t, src, `runtime.WriteBadRequest(w, "invalid query parameter: active")`)
+
+	// Check optional boolean parameter handling
+	require.Contains(t, src, `if qs := r.URL.Query().Get("verified"); qs != ""`)
+	require.Contains(t, src, `strconv.ParseBool(qs)`)
+	require.Contains(t, src, `req.Verified = v`)
+	require.Contains(t, src, `runtime.WriteBadRequest(w, "invalid query parameter: verified")`)
+
+	// strconv should be imported for bool params
+	require.Contains(t, src, `"strconv"`)
+}