fix(validation): use runtime config validation entrypoint

Author: gildesmarais

bin/validate_configs

@@ -3,14 +3,12 @@
 
 require 'bundler/setup'
 require 'html2rss'
-require 'yaml'
 
 files = Dir['lib/html2rss/configs/**/*.yml']
 failed = []
 
 files.each do |file|
-  config = YAML.safe_load_file(file, symbolize_names: true)
-  result = Html2rss::Config.validate(config)
+  result = Html2rss::Config.validate_yaml(file)
 
   if result.success?
     puts "ok   #{file}"

spec/bin/validate_configs_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require 'fileutils'
+require 'stringio'
+require 'tmpdir'
+
+RSpec.describe 'bin/validate_configs' do
+  let(:script_path) { File.expand_path('../../bin/validate_configs', __dir__) }
+
+  it 'passes validation for parameterized configs when defaults are present' do
+    config = <<~YAML
+      parameters:
+        query:
+          type: string
+          default: ruby
+      headers:
+        X-Query: "%<query>s"
+      channel:
+        url: "https://example.com/search?q=%<query>s"
+      selectors:
+        items:
+          selector: ".item"
+        title:
+          selector: "h2"
+    YAML
+
+    Dir.mktmpdir do |dir|
+      FileUtils.mkdir_p(File.join(dir, 'lib', 'html2rss', 'configs', 'example.com'))
+      File.write(File.join(dir, 'lib', 'html2rss', 'configs', 'example.com', 'search.yml'), config)
+
+      stdout = StringIO.new
+      stderr = StringIO.new
+      original_stdout = $stdout
+      original_stderr = $stderr
+      $stdout = stdout
+      $stderr = stderr
+
+      Dir.chdir(dir) { load script_path }
+
+      expect(stdout.string).to include('ok   lib/html2rss/configs/example.com/search.yml')
+      expect(stdout.string).to include('1 configs validated successfully.')
+      expect(stderr.string).to be_empty
+    ensure
+      $stdout = original_stdout
+      $stderr = original_stderr
+    end
+  end
+end

spec/spec_helper.rb

@@ -2,6 +2,10 @@
 
 require 'bundler/setup'
 require 'tzinfo'
+
+local_html2rss_lib = File.expand_path('../../html2rss/lib', __dir__)
+$LOAD_PATH.unshift(local_html2rss_lib) if File.directory?(local_html2rss_lib)
+
 require 'html2rss'
 require 'html2rss/configs'