feat: setup dynamic rspec testing / good-bye manual test creation

Author: gildesmarais

Makefile

@@ -16,6 +16,41 @@ test-fetch-all-configs:
 
 test-all: test test-fetch-all-configs
 
+# Dynamic test commands
+test-config:
+	@if [ -z "$(CONFIG)" ]; then \
+		echo "Usage: make test-config CONFIG=github.com/releases.yml"; \
+		echo "       make test-config CONFIG=github.com"; \
+		exit 1; \
+	fi
+	bundle exec rspec --example "$(CONFIG)" spec/html2rss/configs_dynamic_spec.rb
+
+test-domain:
+	@if [ -z "$(DOMAIN)" ]; then \
+		echo "Usage: make test-domain DOMAIN=github.com"; \
+		exit 1; \
+	fi
+	bundle exec rspec --example "$(DOMAIN)" spec/html2rss/configs_dynamic_spec.rb
+
+test-debug:
+	@if [ -z "$(CONFIG)" ]; then \
+		echo "Usage: make test-debug CONFIG=github.com/releases.yml"; \
+		exit 1; \
+	fi
+	DEBUG_CONFIG=$(CONFIG) bundle exec rspec spec/html2rss/configs_dynamic_spec.rb
+
+# Migration commands
+migrate-tests:
+	bin/migrate_to_dynamic_tests
+
+restore-tests:
+	@if [ -d "spec/html2rss/configs_backup" ]; then \
+		cp -r spec/html2rss/configs_backup/* spec/html2rss/configs/; \
+		echo "✅ Restored tests from backup"; \
+	else \
+		echo "❌ No backup found"; \
+	fi
+
 lintfix:
 	bundle exec rubocop -a
 	npx prettier --write lib/**/*.yml .github/**/*.yml README.md

README.md

@@ -24,6 +24,23 @@ channel:
 
 The `type` field specifies the parameter type (currently only `string` is supported), and `default` provides the default value when no parameter is explicitly provided.
 
+## Testing
+
+Uses **dynamic test generation** - no individual spec files needed!
+
+```bash
+# Test all configs
+bundle exec rspec spec/html2rss/configs_dynamic_spec.rb
+
+# Test specific config
+make test-config CONFIG=github.com/releases.yml
+
+# Test domain
+make test-domain DOMAIN=github.com
+```
+
+**Adding new configs**: Just create the YAML file and run tests. No spec file needed.
+
 ## Documentation
 
 - [Main Documentation](https://html2rss.github.io/html2rss-configs/)

bin/rspec_changed_configs

@@ -3,14 +3,16 @@
 
 changed_files = `git diff --name-only origin/master | grep 'lib/html2rss/configs/.*/.*.yml'`.split("\n")
 
-specs_to_run = changed_files.filter_map do |file|
-  filepath = File.expand_path File.join(__dir__, '..', file)
+if changed_files.count.positive?
+  # Use dynamic test file with environment variable to filter changed configs
+  config_names = changed_files.map { |file| file.sub('lib/html2rss/configs/', '') }
 
-  "#{file.gsub('lib/', 'spec/')}_spec.rb" if File.exist?(filepath)
-end
-
-if specs_to_run.count.positive?
-  exec "bundle exec rspec --tag fetch #{specs_to_run.join(' ')}"
+  # Test each changed config individually
+  config_names.each do |config_name|
+    puts "Testing changed config: #{config_name}"
+    system("bundle exec rspec --example '#{config_name}' --tag fetch spec/html2rss/configs_dynamic_spec.rb")
+  end
 else
+  puts 'No changed config files found'
   exit 0
 end

spec/html2rss/configs_dynamic_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+RSpec.describe Html2rss::Configs do
+  # Get all YAML config files
+  config_files = Dir.glob('lib/html2rss/configs/**/*.yml')
+
+  # Filter by environment variable if specified
+  config_files = config_files.select { |f| f.include?(ENV['TEST_CONFIG']) } if ENV['TEST_CONFIG']
+
+  # Filter by RSpec example pattern if specified
+  if RSpec.configuration.filter_manager.inclusions.rules[:example]
+    pattern = RSpec.configuration.filter_manager.inclusions.rules[:example].first
+    config_files = config_files.select { |f| f.include?(pattern) }
+  end
+
+  config_files.each do |config_file|
+    relative_path = config_file.sub('lib/html2rss/configs/', '')
+    config_name = relative_path.tr('/', '_').gsub('.yml', '')
+    domain = relative_path.split('/').first
+
+    describe "#{relative_path} (#{config_name})", config: config_name, domain: domain do
+      it_behaves_like 'config.yml', relative_path
+
+      # Add debugging hook for specific configs
+      if ENV['DEBUG_CONFIG'] == relative_path
+        it 'debugs the config' do
+          puts "Debugging config: #{relative_path}"
+          puts "File path: #{config_file}"
+          puts "Config name: #{config_name}"
+          puts "Domain: #{domain}"
+          expect(relative_path).to be_a(String) # Add meaningful expectation
+        end
+      end
+    end
+  end
+end