feat: setup dynamic rspec testing / good-bye manual test creation (#255)

* feat: setup dynamic rspec testing / good-bye manual test creation

* feat: remove test files / not-required any longer

* fix: add missing default param

Author: gildesmarais

Makefile

@@ -16,6 +16,41 @@ test-fetch-all-configs:
 
 test-all: test test-fetch-all-configs
 
+# Dynamic test commands
+test-config:
+	@if [ -z "$(CONFIG)" ]; then \
+		echo "Usage: make test-config CONFIG=github.com/releases.yml"; \
+		echo "       make test-config CONFIG=github.com"; \
+		exit 1; \
+	fi
+	bundle exec rspec --example "$(CONFIG)" spec/html2rss/configs_dynamic_spec.rb
+
+test-domain:
+	@if [ -z "$(DOMAIN)" ]; then \
+		echo "Usage: make test-domain DOMAIN=github.com"; \
+		exit 1; \
+	fi
+	bundle exec rspec --example "$(DOMAIN)" spec/html2rss/configs_dynamic_spec.rb
+
+test-debug:
+	@if [ -z "$(CONFIG)" ]; then \
+		echo "Usage: make test-debug CONFIG=github.com/releases.yml"; \
+		exit 1; \
+	fi
+	DEBUG_CONFIG=$(CONFIG) bundle exec rspec spec/html2rss/configs_dynamic_spec.rb
+
+# Migration commands
+migrate-tests:
+	bin/migrate_to_dynamic_tests
+
+restore-tests:
+	@if [ -d "spec/html2rss/configs_backup" ]; then \
+		cp -r spec/html2rss/configs_backup/* spec/html2rss/configs/; \
+		echo "✅ Restored tests from backup"; \
+	else \
+		echo "❌ No backup found"; \
+	fi
+
 lintfix:
 	bundle exec rubocop -a
 	npx prettier --write lib/**/*.yml .github/**/*.yml README.md

README.md

@@ -3,14 +3,16 @@
 
 changed_files = `git diff --name-only origin/master | grep 'lib/html2rss/configs/.*/.*.yml'`.split("\n")
 
-specs_to_run = changed_files.filter_map do |file|
-  filepath = File.expand_path File.join(__dir__, '..', file)
+if changed_files.count.positive?
+  # Use dynamic test file with environment variable to filter changed configs
+  config_names = changed_files.map { |file| file.sub('lib/html2rss/configs/', '') }
 
-  "#{file.gsub('lib/', 'spec/')}_spec.rb" if File.exist?(filepath)
-end
-
-if specs_to_run.count.positive?
-  exec "bundle exec rspec --tag fetch #{specs_to_run.join(' ')}"
+  # Test each changed config individually
+  config_names.each do |config_name|
+    puts "Testing changed config: #{config_name}"
+    system("bundle exec rspec --example '#{config_name}' --tag fetch spec/html2rss/configs_dynamic_spec.rb")
+  end
 else
+  puts 'No changed config files found'
   exit 0
 end

bin/rspec_changed_configs

@@ -1,4 +1,9 @@
 ---
+parameters:
+  section:
+    type: string
+    default: "news"
+
 channel:
   url: https://apnews.com/%<section>s
   language: en

lib/html2rss/configs/apnews.com/hub.yml

@@ -1,4 +1,12 @@
 ---
+parameters:
+  section:
+    type: string
+    default: "news"
+  sub:
+    type: string
+    default: "tech"
+
 channel:
   url: https://www.cnet.com/%<section>s/%<sub>s/
   language: en

lib/html2rss/configs/cnet.com/section_sub.yml

@@ -1,4 +1,9 @@
 ---
+parameters:
+  region:
+    type: string
+    default: "berlin"
+
 channel:
   url: https://www.webentwickler-jobs.de/in/%<region>s
   language: de