test: address PR review feedback for browserless lane

Author: gildesmarais

README.md

@@ -82,7 +82,6 @@ make test-fetch-all-configs
 
 # Run the Browserless-backed fetch subset
 BROWSERLESS_IO_WEBSOCKET_URL=ws://127.0.0.1:4002 \
-BROWSERLESS_IO_API_TOKEN=... \
 make test-fetch-browserless-configs
 ```
 

lib/html2rss/configs/apple.com/newsroom.yml

@@ -8,7 +8,7 @@ channel:
   ttl: 360
 selectors:
   items:
-    selector: 'li.tile-item a.tile-hero, li.tile-item a.tile-2up, li.tile-item a.tile-3up, li.tile-item a.tile-list'
+    selector: "li.tile-item a.tile-hero, li.tile-item a.tile-2up, li.tile-item a.tile-3up, li.tile-item a.tile-list"
     enhance: false
   title:
     selector: .tile__headline

lib/html2rss/configs/spotify.com/newsroom.yml

@@ -8,7 +8,7 @@ channel:
   ttl: 360
 selectors:
   items:
-    selector: '.post-box.v2'
+    selector: ".post-box.v2"
     enhance: false
   title:
     selector: 'h3 a[href*="/20"]'

spec/browserless_fetch_configs_spec.rb

@@ -32,5 +32,12 @@
 
       expect(described_class.browserless_env_configured?).to be(false)
     end
+
+    it 'accepts non-local websocket URLs when a token is present' do
+      ENV['BROWSERLESS_IO_WEBSOCKET_URL'] = 'wss://production.browserless.example/ws'
+      ENV['BROWSERLESS_IO_API_TOKEN'] = 'secret-token'
+
+      expect(described_class.browserless_env_configured?).to be(true)
+    end
   end
 end

spec/support/shared_examples/config.yml_spec.rb

@@ -14,7 +14,6 @@
     config = {}.merge Html2rss::Configs.find_by_name(feed_name)
     # Reuse runtime browser defaults so fetch specs exercise the same header shape as production.
     config[:headers] = Html2rss::Config::RequestHeaders.browser_defaults.merge(config.fetch(:headers, {}))
-    config[:strategy] = :browserless if BrowserlessFetchConfigs.include?(file_name)
 
     # Use provided params or extract defaults from parameters section
     if params
@@ -105,7 +104,7 @@
     subject(:feed) { Html2rss.feed(config.dup) }
 
     before do
-      next unless BrowserlessFetchConfigs.include?(file_name)
+      next unless config[:strategy].to_s == 'browserless'
       next if BrowserlessFetchConfigs.browserless_env_configured?
 
       skip(
@@ -141,7 +140,7 @@
     let(:text_attributes) { specified_attributes & %w[title description author] }
 
     before do
-      next unless BrowserlessFetchConfigs.include?(file_name)
+      next unless config[:strategy].to_s == 'browserless'
       next if BrowserlessFetchConfigs.browserless_env_configured?
 
       skip(