Improve mobile footer flow and degraded-feed messaging

Author: gildesmarais

app/web/rendering/feed_notice_text.rb

@@ -6,19 +6,17 @@ module Web
     # Shared copy helpers for rendered feed warnings and fallback documents.
     module FeedNoticeText
       EMPTY_FEED_DESCRIPTION_TEMPLATE = <<~DESC
-        Unable to extract content from %<url>s using the %<strategy>s strategy.
-        The site may rely on JavaScript, block automated requests, or expose a structure that needs a different parser.
+        We could not extract entries from %<url>s right now.
+        The source may block automated requests, require dynamic rendering, or be temporarily unavailable.
       DESC
 
       EMPTY_FEED_ITEM_TEMPLATE = <<~DESC
         No entries were extracted from %<url>s.
-        Possible causes:
-        - JavaScript-heavy site (try the browserless strategy)
-        - Anti-bot protection
-        - Complex or changing markup
-        - Site blocking automated requests
 
-        Try another strategy or reach out to the site owner.
+        What you can do:
+        - Try again in a few moments
+        - Open the original page to confirm content is available
+        - Reach out to the site owner if access is restricted
       DESC
 
       class << self

app/web/rendering/json_feed_builder.rb

@@ -75,7 +75,7 @@ def build_single_item(item)
         # @return [Hash{Symbol=>String}]
         def empty_feed_item(url)
           {
-            title: 'Content Extraction Failed',
+            title: 'Preview unavailable for this source',
             content_text: FeedNoticeText.empty_feed_item(url: url),
             url: url
           }

app/web/rendering/xml_builder.rb

@@ -53,7 +53,7 @@ def build_empty_feed_warning(url:, strategy:, site_title: nil)
           build_single_item_feed(
             title: FeedNoticeText.empty_feed_title(site_title),
             description: FeedNoticeText.empty_feed_description(url: url, strategy: strategy),
-            item: { title: 'Content Extraction Failed', description: FeedNoticeText.empty_feed_item(url: url),
+            item: { title: 'Preview unavailable for this source', description: FeedNoticeText.empty_feed_item(url: url),
                     link: url },
             link: url
           )

frontend/src/__tests__/ResultDisplay.test.tsx

@@ -102,6 +102,30 @@ describe('ResultDisplay', () => {
     });
   });
 
+  it('keeps feed-ready actions visible while showing preview degradation warning copy', async () => {
+    render(
+      <ResultDisplay
+        result={{
+          ...mockResult,
+          readinessPhase: 'feed_ready',
+          preview: { items: [], error: 'Preview unavailable right now.', isLoading: false },
+        }}
+        workflowState="ready"
+        onCreateAnother={mockOnCreateAnother}
+        onRetryReadiness={mockOnRetryReadiness}
+      />
+    );
+
+    await waitFor(() => {
+      expect(screen.getByText('Feed ready')).toBeInTheDocument();
+      expect(
+        screen.getByText('Feed link is usable, but preview content could not be verified yet.')
+      ).toBeInTheDocument();
+      expect(screen.getByRole('link', { name: 'Open feed' })).toBeInTheDocument();
+      expect(screen.getByText('Preview unavailable right now.')).toBeInTheDocument();
+    });
+  });
+
   it('keeps result shell visible while readiness check is in progress', async () => {
     render(
       <ResultDisplay

frontend/src/components/ResultDisplay.tsx

@@ -32,6 +32,7 @@ export function ResultDisplay({
   const canManuallyRetryReadiness =
     readinessPhase === 'feed_not_ready_yet' || readinessPhase === 'preview_unavailable';
   const isReadinessCheckInProgress = readinessPhase === 'link_created' && preview.isLoading;
+  const hasPreviewDegradation = readinessPhase === 'feed_ready' && Boolean(preview.error);
   const showReadinessAction = canManuallyRetryReadiness || isReadinessCheckInProgress;
   const previewItems = showAllPreviewItems ? preview.items : preview.items.slice(0, 3);
   const hasMorePreviewItems = preview.items.length > 3;
@@ -83,6 +84,11 @@ export function ResultDisplay({
             <h1 class="result-title ui-display-title">{statusTitle}</h1>
             <p class="result-meta layout-rail-copy">{feed.name}</p>
             <p class="field-help">{statusMessage}</p>
+            {hasPreviewDegradation && (
+              <p class="field-help field-help--warning">
+                Feed link is usable, but preview content could not be verified yet.
+              </p>
+            )}
           </div>
         </div>
         <div class="result-hero__actions ui-hero__actions">

frontend/src/styles/main.css

@@ -11,6 +11,9 @@
 }
 
 .page-main {
+  min-height: 100%;
+  display: flex;
+  flex-direction: column;
   width: 100%;
   max-width: var(--layout-page-max-width);
   margin: 0 auto;
@@ -191,6 +194,10 @@
   color: var(--danger);
 }
 
+.field-help--warning {
+  color: var(--text-body);
+}
+
 .input {
   width: 100%;
   min-width: 0;
@@ -693,7 +700,7 @@ a:focus-visible {
 
 @media (width < 48rem) {
   .page-shell {
-    --footer-nav-reserve: calc(12rem + env(safe-area-inset-bottom, 0px));
+    --footer-nav-reserve: 0px;
   }
 
   .page-main,
@@ -761,15 +768,29 @@ a:focus-visible {
   }
 
   .app-footer {
-    padding-top: var(--space-3);
-    background: linear-gradient(180deg, transparent 0%, rgb(var(--color-rgb-black) / 76%) 46%);
+    position: static;
+    inset-inline: auto;
+    bottom: auto;
+    z-index: auto;
+    margin-top: auto;
+    padding: var(--space-5) var(--space-3) calc(var(--space-3) + env(safe-area-inset-bottom, 0px));
+    border-top: 1px solid var(--border-subtle);
+    background: transparent;
+    backdrop-filter: none;
   }
 
   .utility-strip__items {
     grid-auto-flow: row;
     grid-auto-columns: 1fr;
     justify-items: center;
-    gap: var(--space-1);
+    gap: calc(var(--space-1) * 0.9);
+  }
+
+  .utility-link,
+  .utility-button {
+    color: var(--text-faint);
+    font-size: var(--font-size-00);
+    opacity: 0.92;
   }
 }
 

public/rss.xsl

@@ -361,7 +361,7 @@
             </div>
           </section>
 
-          <xsl:if test="rss/channel/title = 'Error' or rss/channel/item[1]/title = 'Content Extraction Failed'">
+          <xsl:if test="rss/channel/title = 'Error' or contains(rss/channel/title, 'Content Extraction Issue') or rss/channel/item[1]/title = 'Content Extraction Failed' or rss/channel/item[1]/title = 'Preview unavailable for this source'">
             <section class="feed-notice ui-card ui-card--notice ui-card--padded layout-rail-reading" aria-label="Feed status">
               <p>
                 <xsl:call-template name="clean-text">

spec/html2rss/web/feed_notice_text_spec.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require_relative '../../../app'
+
+RSpec.describe Html2rss::Web::FeedNoticeText do
+  describe '.empty_feed_item' do
+    subject(:message) { described_class.empty_feed_item(url: 'https://example.com/articles') }
+
+    it 'includes actionable product guidance' do
+      expect(message).to include('What you can do:')
+      expect(message).to include('Try again in a few moments')
+    end
+
+    it 'does not mention hidden strategy controls' do
+      expect(message).not_to include('browserless strategy')
+      expect(message).not_to include('Try another strategy')
+    end
+  end
+end

spec/html2rss/web/json_feed_builder_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require_relative '../../../app'
+
+RSpec.describe Html2rss::Web::JsonFeedBuilder do
+  describe '.build_empty_feed_warning' do
+    subject(:payload) do
+      JSON.parse(
+        described_class.build_empty_feed_warning(
+          url: 'https://example.com/articles',
+          strategy: 'faraday',
+          site_title: 'Example Site'
+        )
+      )
+    end
+
+    it 'uses updated channel description copy' do
+      expect(payload.fetch('description')).to include('We could not extract entries')
+      expect(payload.fetch('description')).not_to include('different parser')
+    end
+
+    it 'uses updated item title and content text' do
+      first_item = payload.fetch('items').first
+      expect(first_item.fetch('title')).to eq('Preview unavailable for this source')
+      expect(first_item.fetch('content_text')).to include('What you can do:')
+    end
+
+    it 'does not mention hidden strategy controls in item text' do
+      first_item = payload.fetch('items').first
+      expect(first_item.fetch('content_text')).not_to include('browserless strategy')
+    end
+  end
+end

spec/html2rss/web/xml_builder_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'nokogiri'
+require_relative '../../../app'
+
+RSpec.describe Html2rss::Web::XmlBuilder do
+  describe '.build_empty_feed_warning' do
+    subject(:xml_doc) do
+      xml = described_class.build_empty_feed_warning(
+        url: 'https://example.com/articles',
+        strategy: 'faraday',
+        site_title: 'Example Site'
+      )
+      Nokogiri::XML(xml)
+    end
+
+    it 'uses updated channel description copy' do
+      description = xml_doc.at_xpath('//channel/description').text
+      expect(description).to include('We could not extract entries')
+      expect(description).not_to include('different parser')
+    end
+
+    it 'uses updated item title and content text' do
+      expect(xml_doc.at_xpath('//item/title').text).to eq('Preview unavailable for this source')
+      expect(xml_doc.at_xpath('//item/description').text).to include('What you can do:')
+    end
+
+    it 'does not mention hidden strategy controls in item text' do
+      expect(xml_doc.at_xpath('//item/description').text).not_to include('browserless strategy')
+    end
+  end
+end