fix: keep unknown api v1 paths inside the api contract

Author: gildesmarais

app/web/routes/api_v1.rb

@@ -22,6 +22,8 @@ def call(router)
               HealthRoutes.call(router)
               FeedRoutes.call(router)
               MetadataRoutes.call(router)
+
+              raise NotFoundError
             end
           end
         end

frontend/src/__tests__/useFeedConversion.contract.test.ts

@@ -21,7 +21,8 @@ describe('useFeedConversion contract', () => {
             feed_token: 'generated-token',
             public_url: '/api/v1/feeds/generated-token',
             json_public_url: '/api/v1/feeds/generated-token.json',
-          })
+          }),
+          { status: 201 }
         );
       })
     );

frontend/src/__tests__/useFeedConversion.test.ts

@@ -42,7 +42,7 @@ describe('useFeedConversion', () => {
           data: { feed: mockResult },
         }),
         {
-          status: 200,
+          status: 201,
           headers: { 'Content-Type': 'application/json' },
         }
       )

spec/html2rss/web/api/v1_spec.rb

@@ -154,6 +154,22 @@ def json_feed_headers_tuple
     end
   end
 
+  describe 'GET /api/v1/unknown', openapi: false do
+    it 'returns a JSON 404 instead of falling through to feed routes', :aggregate_failures do
+      get '/api/v1/unknown'
+
+      expect(last_response.status).to eq(404)
+      expect(last_response.content_type).to include('application/json')
+      expect(JSON.parse(last_response.body)).to include(
+        'success' => false,
+        'error' => include(
+          'message' => Html2rss::Web::NotFoundError::DEFAULT_MESSAGE,
+          'code' => Html2rss::Web::NotFoundError::CODE
+        )
+      )
+    end
+  end
+
   describe 'GET /api/v1/health', openapi: {
     summary: 'Authenticated health check',
     operation_id: 'getHealthStatus',