Skip to content

Commit b55c69d

Browse files
authored
chore: local env defaults and update dev deps (#925)
This pull request introduces several small improvements to the development environment and configuration files. The changes focus on enhancing developer experience, improving local development defaults, and updating ignore patterns for frontend builds. Configuration and environment improvements: * Updated the `docker-compose.yml` service environment variables to provide default values (`local`) for `BUILD_TAG` and `GIT_SHA`, making local development setup easier without requiring these variables to be set explicitly. * Added `yaml-dev` to the list of packages installed in the `.devcontainer/Dockerfile`, ensuring YAML development dependencies are available in the dev container. Frontend build and output management: * Updated `.prettierignore` in the frontend to ignore the `dist/` directory, preventing generated build output from being formatted or linted by Prettier.
1 parent 2d38633 commit b55c69d

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

.devcontainer/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ RUN apk add --no-cache \
1313
npm \
1414
openssl-dev \
1515
python3 \
16+
yaml-dev \
1617
tzdata
1718

1819
ARG USER=vscode

docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ services:
1313
environment:
1414
RACK_ENV: production
1515
PORT: 4000
16-
BUILD_TAG: ${BUILD_TAG:?set BUILD_TAG}
17-
GIT_SHA: ${GIT_SHA:?set GIT_SHA}
16+
BUILD_TAG: ${BUILD_TAG:-local}
17+
GIT_SHA: ${GIT_SHA:-local}
1818
HTML2RSS_SECRET_KEY: ${HTML2RSS_SECRET_KEY:?set HTML2RSS_SECRET_KEY}
1919
HEALTH_CHECK_TOKEN: ${HEALTH_CHECK_TOKEN:?set HEALTH_CHECK_TOKEN}
2020
SENTRY_DSN: ${SENTRY_DSN:-}

frontend/.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ yarn.lock
44

55
# Generated and transient frontend output
66
.astro/
7+
dist/
78
test-results/
89
src/api/generated/

0 commit comments

Comments
 (0)