A few more changes post-review

Author: marktriggs

frontend/assets/user_defined_in_basic.js

@@ -1,7 +1,7 @@
 function UserDefinedInBasic() {
 }
 
-UserDefinedInBasic.prototype.init = function(record_type, fields, read_only_view) {
+UserDefinedInBasic.prototype.init = function(fields, read_only_view) {
     var bi = $("#basic_information");
 
     if (bi.length == 0) {

frontend/views/layout_head.html.erb

@@ -10,13 +10,16 @@ end
     <%= javascript_include_tag "#{AppConfig[:frontend_prefix]}assets/user_defined_in_basic.js" %>
 
     <script>
-     var record_type = '<%= controller.controller_name %>';
      var fields = <%= ASUtils.to_json(map_user_defined_to_labels(AppConfig[:user_defined_in_basic].fetch(controller.controller_name, []))).html_safe %>;
      var read_only_view = <%= controller.action_name == 'show' %>;
 
      var init = function () {
+         // Funny setTimeout here to move our initialization to the
+         // end of the page load.  We need this to run after the user
+         // defined field subform is in and its buttons have been wired
+         // up.
          setTimeout(function () {
-             new UserDefinedInBasic().init(record_type, fields, read_only_view);
+             new UserDefinedInBasic().init(fields, read_only_view);
          }, 0);
      }
 

frontend/views/user_defined/_show.html.erb

@@ -1,16 +1,13 @@
 <%
   section_id = "user_defined" if section_id.blank?
-  if !defined?(context) || !context
-      context = {}
-  end
 %>
 
 <section id="<%= section_id %>" class="subrecord-form-dummy">
   <h3><%= I18n.t("user_defined._singular") %></h3>
 
   <div class="subrecord-form-container">
     <div class="subrecord-form-fields">
-      <%= read_only_view(user_defined, 'parent' => context['jsonmodel_type']) %>
+      <%= read_only_view(user_defined) %>
     </div>
   </div>
 </section>