Skip to content

Commit 02063e6

Browse files
Fix TypeError in rope validation when ignore_keys is a list (#45069)
`_check_received_keys` performs `received_keys -= ignore_keys` where `received_keys` is a `set`. When model configs are loaded from JSON (e.g. via huggingface_hub dataclass validation), sets get deserialized as lists since JSON has no set type, causing: TypeError: unsupported operand type(s) for -=: 'set' and 'list' Wrapping with `set()` handles both cases (no-op for sets, converts lists). Fixes #45068 Co-authored-by: IrinaArmstrong <a.irene.a@mail.ru>
1 parent 2da00a3 commit 02063e6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/transformers/modeling_rope_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,7 @@ def _check_received_keys(
916916

917917
# Some models need to store model-specific keys, and we don't want to throw warning at them
918918
if ignore_keys is not None:
919-
received_keys -= ignore_keys
919+
received_keys -= set(ignore_keys)
920920

921921
missing_keys = required_keys - received_keys
922922
if missing_keys:

0 commit comments

Comments
 (0)