Skip to content

Commit d054353

Browse files
committed
Fix redundant NPU validation reruns
1 parent c34e13b commit d054353

2 files changed

Lines changed: 2 additions & 9 deletions

File tree

test/npu_validation/scripts/run_remote_npu_validation.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -296,11 +296,7 @@ while IFS= read -r -d '' cpp; do
296296
fi
297297
python3 ./golden.py
298298
LD_LIBRARY_PATH="${LD_LIBRARY_PATH_NPU}" ./build/${testcase}
299-
if [[ "${CUSTOM_GOLDEN}" != "1" ]]; then
300-
copy_outputs_as_golden
301-
python3 ./golden.py
302-
LD_LIBRARY_PATH="${LD_LIBRARY_PATH_NPU}" ./build/${testcase}
303-
else
299+
if [[ "${CUSTOM_GOLDEN}" == "1" ]]; then
304300
log "Using custom golden for ${testcase}"
305301
fi
306302
COMPARE_STRICT=1 python3 ./compare.py

test/npu_validation/templates/run_sh_template.sh

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ BUILD_DIR="${BUILD_DIR:-build}"
99
ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
1010

1111
cd "${ROOT_DIR}"
12-
python3 "${ROOT_DIR}/golden.py"
1312

1413
# Best-effort resolve PTO_ISA_ROOT for generated CMakeLists.txt.
1514
if [[ -z "${PTO_ISA_ROOT:-}" ]]; then
@@ -104,6 +103,7 @@ copy_outputs_as_golden() {
104103

105104
case "${GOLDEN_MODE}" in
106105
sim)
106+
python3 "${ROOT_DIR}/golden.py"
107107
LD_LIBRARY_PATH="${LD_LIBRARY_PATH_SIM}" "${ROOT_DIR}/${BUILD_DIR}/@EXECUTABLE@_sim"
108108
copy_outputs_as_golden
109109
if [[ "${RUN_MODE}" == "npu" ]]; then
@@ -118,9 +118,6 @@ case "${GOLDEN_MODE}" in
118118
fi
119119
python3 "${ROOT_DIR}/golden.py"
120120
LD_LIBRARY_PATH="${LD_LIBRARY_PATH_NPU}" "${ROOT_DIR}/${BUILD_DIR}/@EXECUTABLE@"
121-
copy_outputs_as_golden
122-
python3 "${ROOT_DIR}/golden.py"
123-
LD_LIBRARY_PATH="${LD_LIBRARY_PATH_NPU}" "${ROOT_DIR}/${BUILD_DIR}/@EXECUTABLE@"
124121
COMPARE_STRICT=1 python3 "${ROOT_DIR}/compare.py"
125122
;;
126123
skip)

0 commit comments

Comments
 (0)