Android purchases not being reported by success handler or listeners

[404-html]

Some purchases not being reported by success handler or listeners.
Same problem as on previous repo: hyochan/react-native-iap#3150 (reported by @renatomserra).

Unfortunately the issue is back again.

react-native-iap: 15.2.0
react-native: 0.81.5

For now I noticed that on Android only.

[gitdogdev]

@404-html ## Issue Summary

Some Android purchases are not being reported to the success handler or listeners in react-native-iap v15.2.0. This is a known issue that occurred in the previous repository (issue #3150).

Root Cause

I found the issue in the Android native code at HybridRnIap.kt:168-218. The purchase listeners are attached to the OpenIAP library only once during initConnection(), controlled by the listenersAttached flag:

private var listenersAttached = false

private fun attachListeners() {
  if (listenersAttached) return
  listenersAttached = true
  
  iap.onPurchaseUpdated.addListener { purchase ->
    // Handle purchase
  }
}

However, when endConnection() is called, the listeners are never detached or the flag is never reset. This means:

1. First connection: Listeners attach successfully ✅
2. Connection ends: Listeners remain attached but flag stays true
3. Second connection attempt: attachListeners() returns early because listenersAttached == true, so new listeners are never registered ❌

Additionally, if the connection fails or is interrupted between purchases, the listener state becomes inconsistent with the actual connection state.

Solution

Option 1: Reset Flag on Disconnect (Recommended)

Modify endConnection() to reset the listeners flag:

fun endConnection() {
  listenersAttached = false  // Add this line
  iap.endConnection()
}

Option 2: Detach Listeners Explicitly

private fun detachListeners() {
  iap.onPurchaseUpdated.removeAllListeners()
  listenersAttached = false
}

fun endConnection() {
  detachListeners()
  iap.endConnection()
}

Option 3: Use WeakReference Pattern

Implement a more robust listener management system that doesn't rely on a boolean flag, using weak references to handle lifecycle changes automatically.

Recommended Implementation

Apply Option 1 as it requires minimal changes and is the most straightforward fix. This ensures listeners are properly re-attached on each new connection.

Testing

After applying the fix, verify that:

• Multiple initConnection() → purchase → endConnection() cycles work correctly
• Purchases are reported in all scenarios
• No duplicate listeners are registered

---

🤖 Generated by gitdog.dev · Have more questions? Tag @gitdog and let me know!

[hyochan]

Thanks for the report. I checked both the current main code and the react-native-iap-15.2.0 tag.

The listenersAttached explanation in the gitdog comment above does not match the code: HybridRnIap.endConnection() already resets listenersAttached = false in 15.2.0, and current main still does. So adding that line is not the fix here.

There has been a related Android Billing reliability fix since 15.2.0: #159 made Play Billing callback bridges single-resume guarded and was released in react-native-iap@15.3.1 / openiap-google@2.2.1. Please try react-native-iap@15.3.1 first.

If this still reproduces on 15.3.1, please share:

• Whether this is in-app or subs
• The requestPurchase payload shape you pass
• React Native logs around initConnection, requestPurchase, purchaseUpdatedListener, and purchaseErrorListener
• Android logcat lines for HybridRnIap / OpenIapModule
• What getAvailablePurchases() returns immediately after the failed/missing callback

With those logs we can tell whether the purchase update callback is not arriving from Play Billing, arrives before JS listener registration, is dropped during conversion/validation, or is related to the already-fixed callback race.