Skip to content

Commit 4532dd7

Browse files
Release
1 parent c8dce3a commit 4532dd7

4 files changed

Lines changed: 30 additions & 57 deletions

File tree

DeviceIdentificator.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -652,6 +652,7 @@
652652
DYLIB_INSTALL_NAME_BASE = "@rpath";
653653
INFOPLIST_FILE = Source/Info.plist;
654654
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
655+
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
655656
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
656657
PRODUCT_BUNDLE_IDENTIFIER = net.s3ba.DeviceIdentificator;
657658
SKIP_INSTALL = YES;
@@ -672,6 +673,7 @@
672673
DYLIB_INSTALL_NAME_BASE = "@rpath";
673674
INFOPLIST_FILE = Source/Info.plist;
674675
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
676+
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
675677
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
676678
PRODUCT_BUNDLE_IDENTIFIER = net.s3ba.DeviceIdentificator;
677679
SKIP_INSTALL = YES;

Source/DeviceModel+Name.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ public extension DeviceModel {
9292
case .appleTV4K2G: return "Apple TV 4K 2G"
9393
case .appleTV4K3G: return "Apple TV 4K 3G"
9494

95-
case .iPadSimulator: return "iPad Simulator"
96-
case .iPhoneSimulator: return "iPhone Simulator"
97-
case .appleTVSimulator: return "Apple TV Simulator"
95+
case .iPadSimulator(let model, let arch): return "iPad Simulator (\(model.name) @ \(arch))"
96+
case .iPhoneSimulator(let model, let arch): return "iPhone Simulator (\(model.name) @ \(arch))"
97+
case .appleTVSimulator(let model, let arch): return "Apple TV Simulator (\(model.name) @ \(arch))"
9898

9999
case .iPhoneUnknown(let model): return "Unknown iPhone (\(model))"
100100
case .iPadUnknown(let model): return "Unknown iPad (\(model))"

Tests/DeviceModelTests.swift

Lines changed: 24 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -12,60 +12,31 @@ public class DeviceModelTests: XCTestCase {
1212
XCTAssertEqual(DeviceModel(rawValue: model.rawValue), model)
1313
}
1414
}
15-
/*
16-
public func testIsSimulator() {
17-
XCTAssertTrue(DeviceModel.iPadSimulator(.iPad1G, arch: "x86").isSimulator)
18-
XCTAssertTrue(DeviceModel.iPhoneSimulator(.iPhone6, arch: "x86").isSimulator)
19-
XCTAssertFalse(DeviceModel.iPhone6Plus.isSimulator)
20-
}
21-
22-
public func testUnknownSimulator() {
23-
let deviceModel32b = DeviceModel(rawValue: "i386")
24-
let deviceModel64b = DeviceModel(rawValue: "x86_64")
25-
26-
switch UI_USER_INTERFACE_IDIOM() {
27-
case .pad:
28-
XCTAssertEqual(deviceModel32b, .iPadSimulator(.iPhone6, arch: "x86"))
29-
XCTAssertEqual(deviceModel64b, .iPadSimulator(.iPhone6, arch: "x86"))
30-
case .phone:
31-
XCTAssertEqual(deviceModel32b, .iPhoneSimulator(.iPad1G, arch: "x86"))
32-
XCTAssertEqual(deviceModel64b, .iPhoneSimulator(.iPad1G, arch: "x86"))
33-
case .tv:
34-
XCTAssertEqual(deviceModel32b, .appleTVSimulator(.appleTV4K, arch: "x86"))
35-
XCTAssertEqual(deviceModel64b, .appleTVSimulator(.appleTV4K, arch: "x86"))
36-
default:
37-
XCTFail("not supported yet")
38-
}
39-
}
40-
41-
public func testKnownModels() {
42-
XCTAssertEqual(DeviceModel(rawValue: "iPhone7,1"), .iPhone6Plus)
43-
XCTAssertEqual(DeviceModel(rawValue: "iPod1,1"), .iPodTouch1G)
44-
XCTAssertEqual(DeviceModel(rawValue: "iPad4,1"), .iPadAir1G)
45-
}
46-
47-
public func testUnknown() {
48-
let identifier = "wawa"
49-
50-
XCTAssertEqual(DeviceModel(rawValue: identifier), .unknown(model: identifier))
51-
}
52-
53-
public func testUnknownIphone() {
54-
let identifier = "iPhone67,21"
55-
56-
XCTAssertEqual(DeviceModel(rawValue: identifier), .iPhoneUnknown(model: identifier))
15+
16+
public func test_iPad_simulator() {
17+
let iPadSimulator = DeviceModel.iPadSimulator(.iPad1G(.celullar), arch: "x86")
18+
19+
XCTAssertTrue(iPadSimulator.isSimulator)
20+
XCTAssertFalse(iPadSimulator.isIphone)
21+
XCTAssertTrue(iPadSimulator.isIpad)
22+
XCTAssertFalse(iPadSimulator.isAppleTV)
5723
}
58-
59-
public func testUnknownIpod() {
60-
let identifier = "iPod67,21"
61-
62-
XCTAssertEqual(DeviceModel(rawValue: identifier), .iPodUnknown(model: identifier))
24+
25+
public func test_iPhone_simulator() {
26+
let iPadSimulator = DeviceModel.iPhoneSimulator(.iPhoneXS, arch: "arm64")
27+
28+
XCTAssertTrue(iPadSimulator.isSimulator)
29+
XCTAssertTrue(iPadSimulator.isIphone)
30+
XCTAssertFalse(iPadSimulator.isIpad)
31+
XCTAssertFalse(iPadSimulator.isAppleTV)
6332
}
64-
65-
public func testUnknownIpad() {
66-
let identifier = "iPad67,21"
67-
68-
XCTAssertEqual(DeviceModel(rawValue: identifier), .iPadUnknown(model: identifier))
33+
34+
public func test_AppleTV_simulator() {
35+
let iPadSimulator = DeviceModel.appleTVSimulator(.appleTV4G, arch: "x86")
36+
37+
XCTAssertTrue(iPadSimulator.isSimulator)
38+
XCTAssertFalse(iPadSimulator.isIphone)
39+
XCTAssertFalse(iPadSimulator.isIpad)
40+
XCTAssertTrue(iPadSimulator.isAppleTV)
6941
}
70-
*/
7142
}

Tests/UIDeviceExtensionsTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ public class DeviceIdentificatorTests: XCTestCase {
55
public func testIsSimulator() {
66
#if targetEnvironment(simulator)
77
XCTAssertTrue(UIDevice.current.isSimulator)
8-
XCTAssertTrue(UIDevice.current.deviceModelName.lowercased.contains("simulator"), UIDevice.current.deviceModelName as String)
8+
XCTAssertTrue(UIDevice.current.deviceModelName.lowercased.contains("simulator"), UIDevice.current.deviceModelName as String)
99
#else
1010
XCTAssertFalse(UIDevice.current.isSimulator)
1111
#endif

0 commit comments

Comments
 (0)