making ErrorHandler resolver required & removing checks

Ahmedmhmud · Ahmedmhmud · commit d24ba98a30ea · 2026-04-14T00:41:48.000+02:00
diff --git a/src/error-handlers/contains.js b/src/error-handlers/contains.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const containsErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getSiblingKeywordValue) {
-    throw new Error("Missing resolver.getSiblingKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
 
diff --git a/src/error-handlers/format.js b/src/error-handlers/format.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const formatErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
 
diff --git a/src/error-handlers/maxItems.js b/src/error-handlers/maxItems.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const maxItemsErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
   let lowestMaxItems = Infinity;
diff --git a/src/error-handlers/maxLength.js b/src/error-handlers/maxLength.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const maxLengthErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
   let lowestMaxLength = Infinity;
diff --git a/src/error-handlers/maxProperties.js b/src/error-handlers/maxProperties.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const maxPropertiesErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
   let lowestMaxProperties = Infinity;
diff --git a/src/error-handlers/maximum.js b/src/error-handlers/maximum.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const maximumErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue || !resolver.getSiblingKeywordValue) {
-    throw new Error("Missing resolver functions in error handler context");
-  }
-
   let lowestMaximum = Infinity;
   let isExclusive = false;
 
diff --git a/src/error-handlers/minItems.js b/src/error-handlers/minItems.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const minItemsErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
   let highestMinItem = 0;
diff --git a/src/error-handlers/minLength.js b/src/error-handlers/minLength.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const minLengthErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
   let highestMinLength = -Infinity;
diff --git a/src/error-handlers/minProperties.js b/src/error-handlers/minProperties.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const minPropertiesErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
 
diff --git a/src/error-handlers/minimum.js b/src/error-handlers/minimum.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const minimumErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue || !resolver.getSiblingKeywordValue) {
-    throw new Error("Missing resolver functions in error handler context");
-  }
-
   let highestMinimum = -Infinity;
   let isExclusive = false;
   /** @type string[] */
diff --git a/src/error-handlers/multipleOf.js b/src/error-handlers/multipleOf.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const multipleOfErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
 
diff --git a/src/error-handlers/pattern.js b/src/error-handlers/pattern.js
@@ -6,10 +6,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const patternErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type ErrorObject[] */
   const errors = [];
 
diff --git a/src/error-handlers/required.js b/src/error-handlers/required.js
@@ -7,10 +7,6 @@ import * as Instance from "@hyperjump/json-schema/instance/experimental";
 
 /** @type ErrorHandler */
 const requiredErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   /** @type {Set<string>} */
   const allMissingRequired = new Set();
   const allSchemaLocations = [];
diff --git a/src/error-handlers/typeConstEnum.js b/src/error-handlers/typeConstEnum.js
@@ -8,10 +8,6 @@ const ALL_TYPES = new Set(["null", "boolean", "number", "string", "array", "obje
 
 /** @type {ErrorHandler} */
 const typeConstEnumErrorHandler = (normalizedErrors, instance, localization, resolver) => {
-  if (!resolver?.getCompiledKeywordValue) {
-    throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-  }
-
   let allowedTypes = new Set(ALL_TYPES);
   /** @type {string[]} */
   const failedTypeLocations = [];
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -154,13 +154,13 @@ export type ErrorResolver = {
  * A function that transforms normalized errors for one or more keywords into human
  * readable messages.
  */
-export type ErrorHandler = (normalizedErrors: InstanceOutput, instance: JsonNode, localization: Localization, resolver?: ErrorResolver) => ErrorObject[];
+export type ErrorHandler = (normalizedErrors: InstanceOutput, instance: JsonNode, localization: Localization, resolver: ErrorResolver) => ErrorObject[];
 
 /**
  * Converts the normalized error format to human readable errors. It's used to
  * build errors in applicator error handlers.
  */
-export const getErrors: (normalizedErrors: NormalizedOutput, instance: JsonNode, localization: Localization, resolver?: ErrorResolver) => ErrorObject[];
+export const getErrors: (normalizedErrors: NormalizedOutput, instance: JsonNode, localization: Localization, resolver: ErrorResolver) => ErrorObject[];
 
 export type { Localization };
 
diff --git a/src/json-schema-errors.js b/src/json-schema-errors.js
@@ -188,15 +188,6 @@ export const getErrors = (normalizedErrors, rootInstance, localization, resolver
   /** @type API.ErrorObject[] */
   const errors = [];
 
-  resolver ??= {
-    getCompiledKeywordValue: () => {
-      throw new Error("Missing resolver.getCompiledKeywordValue in error handler context");
-    },
-    getSiblingKeywordValue: () => {
-      throw new Error("Missing resolver.getSiblingKeywordValue in error handler context");
-    }
-  };
-
   for (const instanceLocation in normalizedErrors) {
     const instance = /** @type JsonNode */ (Instance.get(instanceLocation, rootInstance));
     for (const errorHandler of errorHandlers) {
