Skip to content

Commit fa12326

Browse files
hyperpolymathclaude
andcommitted
Remove template-only ABI files that falsely implied formal verification
Template Idris2 ABI files (Types.idr, Layout.idr, Foreign.idr) contained only RSR template scaffolding with unresolved placeholders and no domain-specific proofs. Removed to prevent false impression of formal verification coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 426444c commit fa12326

5 files changed

Lines changed: 87 additions & 626 deletions

File tree

PROOF-NEEDS.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# PROOF-NEEDS.md
2+
<!-- SPDX-License-Identifier: PMPL-1.0-or-later -->
3+
4+
## Current State
5+
6+
- **LOC**: ~3,610
7+
- **Languages**: Rust, Julia, Idris2, Zig
8+
- **Existing ABI proofs**: `src/abi/*.idr` (template-level)
9+
- **Dangerous patterns**: None detected
10+
11+
## What Needs Proving
12+
13+
### VAE Dataset Normalization (Julia core)
14+
- `contrastive_model.jl`, `julia_utils.jl` — data processing pipeline
15+
- Prove: normalization is invertible (or document when it is lossy)
16+
- Prove: contrastive model training preserves dataset statistical properties
17+
18+
### Metadata Handling (src/metadata.rs)
19+
- Dataset metadata management
20+
- Prove: metadata correctly describes the normalized dataset
21+
22+
### Fuzz Target (fuzz/fuzz_targets/fuzz_input.rs)
23+
- Fuzzing exists — formal proofs of normalization properties would be stronger
24+
25+
## Recommended Prover
26+
27+
- **Lean4** with Mathlib for numerical/statistical properties
28+
- **Idris2** for ABI layer and metadata invariants
29+
30+
## Priority
31+
32+
**LOW** — Dataset preprocessing tool. Normalization correctness matters for ML pipeline reproducibility but is not safety-critical. The small codebase limits the scope of potential errors.
33+
34+
## Template ABI Cleanup (2026-03-29)
35+
36+
Template ABI removed -- was creating false impression of formal verification.
37+
The removed files (Types.idr, Layout.idr, Foreign.idr) contained only RSR template
38+
scaffolding with unresolved {{PROJECT}}/{{AUTHOR}} placeholders and no domain-specific proofs.

TEST-NEEDS.md

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# TEST-NEEDS: zerostep
2+
3+
## Current State
4+
5+
| Category | Count | Details |
6+
|----------|-------|---------|
7+
| **Source modules** | 7 | Rust (main, metadata), Julia (contrastive_model, julia_utils), 3 Idris2 ABI |
8+
| **Unit tests** | 5 | test/runtests.jl (5 @test) |
9+
| **Integration tests** | 0 | None |
10+
| **E2E tests** | 0 | None |
11+
| **Benchmarks** | 0 | None |
12+
| **Fuzz tests** | 1 | fuzz/fuzz_targets/fuzz_input.rs |
13+
14+
## What's Missing
15+
16+
### P2P Tests
17+
- [ ] No tests for Rust <-> Julia interop
18+
- [ ] No tests for contrastive model feeding into metadata processing
19+
20+
### E2E Tests
21+
- [ ] No test running zerostep binary end-to-end
22+
- [ ] No test for the contrastive learning pipeline
23+
24+
### Aspect Tests
25+
- [ ] **Security**: No input validation tests
26+
- [ ] **Performance**: ML contrastive model with 0 benchmarks
27+
- [ ] **Concurrency**: No tests for parallel model execution
28+
- [ ] **Error handling**: No tests for malformed input data, model failures
29+
30+
### Build & Execution
31+
- [ ] No Rust compilation test
32+
- [ ] No Idris2 ABI compilation test
33+
- [ ] Nickel config (config.ncl) untested
34+
35+
### Benchmarks Needed
36+
- [ ] Contrastive model training time
37+
- [ ] Inference latency
38+
- [ ] Metadata processing throughput
39+
40+
### Self-Tests
41+
- [ ] No self-diagnostic mode
42+
43+
## FLAGGED ISSUES
44+
- **5 @test for 7 source modules** = barely tested
45+
- **ML project with 0 benchmarks** -- performance is the entire point
46+
- **Fuzz target exists** (fuzz_input.rs) -- rare positive
47+
- **Julia model code with no Julia-specific tests** for the model itself
48+
49+
## Priority: P1 (HIGH)

src/abi/Foreign.idr

Lines changed: 0 additions & 217 deletions
This file was deleted.

0 commit comments

Comments
 (0)