refactoring correctnes code

Author: telmomenezes

src/hyperbase/correctness.py

@@ -108,30 +108,14 @@ def _check_edge(edge: Hyperedge) -> dict[Hyperedge, list[tuple[str, str]]]:
                     )
 
                 ars_counts = Counter(ars)
-                if ars_counts["s"] > 1:
-                    errors.append(
-                        ("argrole-s-1-max", "argrole s can only be used once")
-                    )
-                if ars_counts["o"] > 1:
-                    errors.append(
-                        ("argrole-o-1-max", "argrole o can only be used once")
-                    )
-                if ars_counts["c"] > 1:
-                    errors.append(
-                        ("argrole-c-1-max", "argrole c can only be used once")
-                    )
-                if ars_counts["i"] > 1:
-                    errors.append(
-                        ("argrole-i-1-max", "argrole i can only be used once")
-                    )
-                if ars_counts["p"] > 1:
-                    errors.append(
-                        ("argrole-p-1-max", "argrole p can only be used once")
-                    )
-                if ars_counts["a"] > 1:
-                    errors.append(
-                        ("argrole-a-1-max", "argrole a can only be used once")
-                    )
+                for role in "socipam":
+                    if ars_counts[role] > 1:
+                        errors.append(
+                            (
+                                f"argrole-{role}-1-max",
+                                f"argrole {role} can only be used once",
+                            )
+                        )
             else:
                 errors.append(
                     (

src/hyperbase/parsers/correctness.py

@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-from collections import Counter
 from typing import Any
 
 from hyperbase.hyperedge import Hyperedge
@@ -21,7 +20,6 @@ def _visit(current_edge: Hyperedge) -> None:
         # Argrole checks
         try:
             ars = current_edge.argroles()
-            ar_counts: Counter[str] = Counter()
             for ar in ars:
                 if ar not in "mspaoixtjrc":
                     current_errors.append(
@@ -32,17 +30,7 @@ def _visit(current_edge: Hyperedge) -> None:
                             2,
                         )
                     )
-                ar_counts[ar] += 1
 
-            for role in "spoiamc":
-                if ar_counts[role] > 1:
-                    current_errors.append(
-                        (
-                            f"duplicate-argrole-{role}",
-                            f"Argument role '{role}' should only be used once.",
-                            2,
-                        )
-                    )
         except Exception:
             pass
 

tests/test_correctness.py

@@ -282,12 +282,12 @@ def test_duplicate_argrole(self):
         for _k, v in errors.items():
             if isinstance(v, list):
                 for err in v:
-                    if isinstance(err, tuple) and err[0] == "duplicate-argrole-s":
+                    if isinstance(err, tuple) and err[0] == "argrole-s-1-max":
                         assert len(err) == 3
-                        assert err[2] == 2
+                        assert err[2] == 0
                         found = True
                         break
-        assert found, "Should detect duplicate argrole 's' with severity 2"
+        assert found, "Should detect duplicate argrole 's'"
 
     def test_invalid_junction_mixed(self):
         # Mixed types C and R