Fixed the case when there is no delivery date yet (#13)

* fixed case when there is no delivery date yet. Fixed test case with letters

* updated version + changelog

* reverted a potential breaking change

* Update postnl_api/items/package.py

Co-Authored-By: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>

Author: 2 people

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.2.1 - 2019-08-18
+### Fixed
+- Resolved an issue when there is no delivery date (yet).
+- Fixed the test case for letters
+
 ## 1.2.0 - 2019-08-08
 ### Added
 - Created packages and letters classes

postnl_api/items/package.py

@@ -8,9 +8,11 @@ def __init__(self, data):
         self.type = data.get("settings").get("box")
         self.status = data.get("status").get("deliveryStatus")
         self.status_message = data.get("status").get("phase").get("message")
-        self.delivery_date = datetime.fromisoformat(
-            data.get("status").get("delivery").get("deliveryDate")
-        )
+        self.delivery_date = None
+        if data.get("status").get("delivery").get("deliveryDate") is not None:
+            self.delivery_date = datetime.fromisoformat(
+                data.get("status").get("delivery").get("deliveryDate")
+            )
         self.planned_date = None
         self.planned_from = None
         self.planned_to = None
@@ -38,4 +40,4 @@ def delivery_today(self):
         return self.delivery_date.date() == datetime.today().date()
 
     def __str__(self):
-        return f"{self.id} {self.name} {self.type} {self.status} {self.status_message} {self.delivery_date.date()} {self.planned_date} {self.planned_from} {self.planned_to}"
+        return f"{self.id} {self.name} {self.type} {self.status} {self.status_message} {self.delivery_date.date() if self.delivery_date else 'Unknown'} {self.planned_date} {self.planned_from} {self.planned_to}"

postnl_api/test_postnl_api.py

@@ -25,7 +25,7 @@ def main():
     print("Listing packages:")
     [print(p) for p in packages]
 
-    if api.is_letters_activated():
+    if api.is_letters_activated:
         letters = api.get_letters()
         print("Number of letters: ", len(letters))
         print("Listing letters:")

setup.py

@@ -5,7 +5,7 @@
 
 setup(
     name="postnl_api",
-    version="1.2.0",
+    version="1.2.1",
     description="Python wrapper for the PostNL API, a way to track packages and letters.",
     long_description=long_description,
     long_description_content_type="text/markdown",