Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Commit 9d8fdc3

Browse files
peternijsseneavanvalkenburg
authored andcommitted
Fixed the case when there is no delivery date yet (#13)
* fixed case when there is no delivery date yet. Fixed test case with letters * updated version + changelog * reverted a potential breaking change * Update postnl_api/items/package.py Co-Authored-By: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
1 parent d30d316 commit 9d8fdc3

4 files changed

Lines changed: 13 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/)
55
and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## 1.2.1 - 2019-08-18
8+
### Fixed
9+
- Resolved an issue when there is no delivery date (yet).
10+
- Fixed the test case for letters
11+
712
## 1.2.0 - 2019-08-08
813
### Added
914
- Created packages and letters classes

postnl_api/items/package.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ def __init__(self, data):
88
self.type = data.get("settings").get("box")
99
self.status = data.get("status").get("deliveryStatus")
1010
self.status_message = data.get("status").get("phase").get("message")
11-
self.delivery_date = datetime.fromisoformat(
12-
data.get("status").get("delivery").get("deliveryDate")
13-
)
11+
self.delivery_date = None
12+
if data.get("status").get("delivery").get("deliveryDate") is not None:
13+
self.delivery_date = datetime.fromisoformat(
14+
data.get("status").get("delivery").get("deliveryDate")
15+
)
1416
self.planned_date = None
1517
self.planned_from = None
1618
self.planned_to = None
@@ -38,4 +40,4 @@ def delivery_today(self):
3840
return self.delivery_date.date() == datetime.today().date()
3941

4042
def __str__(self):
41-
return f"{self.id} {self.name} {self.type} {self.status} {self.status_message} {self.delivery_date.date()} {self.planned_date} {self.planned_from} {self.planned_to}"
43+
return f"{self.id} {self.name} {self.type} {self.status} {self.status_message} {self.delivery_date.date() if self.delivery_date else 'Unknown'} {self.planned_date} {self.planned_from} {self.planned_to}"

postnl_api/test_postnl_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def main():
2525
print("Listing packages:")
2626
[print(p) for p in packages]
2727

28-
if api.is_letters_activated():
28+
if api.is_letters_activated:
2929
letters = api.get_letters()
3030
print("Number of letters: ", len(letters))
3131
print("Listing letters:")

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
setup(
77
name="postnl_api",
8-
version="1.2.0",
8+
version="1.2.1",
99
description="Python wrapper for the PostNL API, a way to track packages and letters.",
1010
long_description=long_description,
1111
long_description_content_type="text/markdown",

0 commit comments

Comments
 (0)