Fix infinite re-render (#194)

Author: souravbentley

common/changes/@itwin/manage-versions-react/sj-fix-infinite-rerender_2026-01-28-17-30.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/manage-versions-react",
+      "comment": "Fix infinite rerender edge case",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@itwin/manage-versions-react"
+}

packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx

@@ -455,26 +455,19 @@ const ManageVersionsComponent = (props: ManageVersionsProps) => {
 
   React.useEffect(() => {
     const loadUsers = async () => {
-      if (!hasMoreUsersRef.current) {
-        return;
-      }
-
+      hasMoreUsersRef.current = false;
       if (!usersRef.current) {
-        hasMoreUsersRef.current = false;
         await getUsers();
       } else {
-        const hasMissingUsers =
-          versionsTableData?.some((td) => !td.version.createdBy) ||
-          changesets?.some((cs) => !cs.createdBy);
-
-        if (hasMissingUsers) {
-          hasMoreUsersRef.current = false;
-          await getUsers(Object.keys(usersRef.current).length);
-        }
+        await getUsers(Object.keys(usersRef.current).length);
       }
     };
 
-    if (!usersRef.current || versionsTableData || changesets) {
+    const hasMissingUsers =
+      versionsTableData?.some((td) => !td.version.createdBy) ||
+      changesets?.some((cs) => !cs.createdBy);
+
+    if (!usersRef.current || (hasMissingUsers && hasMoreUsersRef.current)) {
       loadUsers()
         .then(() => {
           const updatedVersionsTableData = versionsTableData?.map((td) => {