Skip to content

Commit 0f5bcce

Browse files
authored
Turning off all properties on Advanced Filtering dialog hides elements incorrectly (#238)
iTwin/changed-elements#121 --------- Co-authored-by: naronchen <naronchen@users.noreply.github.com>
1 parent 0ff6e7e commit 0f5bcce

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

.changeset/tender-camels-report.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@itwin/changed-elements-react": patch
3+
---
4+
5+
bug fix- Turning off all properties on Advanced Filtering dialog hides elements incorrectly

packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,6 +1011,11 @@ export class ChangedElementsListComponent extends Component<ChangedElementsListP
10111011
return true;
10121012
}
10131013

1014+
// keep the entry if user has typeOfChange filtering other than properties checked and matches
1015+
if (((entry.type & ~TypeOfChange.Property) & (options.wantedTypeOfChange)) !== 0) {
1016+
return true;
1017+
}
1018+
10141019
// Only thing left to do is to check that the entry's properties are visible in filters
10151020
return this._anyEntryPropertiesVisible(entry, options);
10161021
};

0 commit comments

Comments
 (0)