Pushed linting and error handling fix

Author: CalebGerman

packages/test-app-frontend/src/App/ITwinJsApp/AppUi/PropertyComparisonTable.tsx

@@ -56,15 +56,15 @@ function mapStateToProps(state: { versionCompareState: VersionCompareState; }, o
           await manager.enableVisualization(true, selection);
           updateVersionComparisonTransparencies(viewports[0], 0.5, 0.5);
         },
-        10000,
+        1000,
       );
     } else if (PropertyComparisonFrontstage.isSideBySide) {
       await VersionCompareFrontstageManager.onViewPortMounts(
         2,
         async () => {
           await manager.enableSideBySideVisualization();
         },
-        10000,
+        1000,
       );
     }
   };

packages/test-app-frontend/src/App/ITwinJsApp/AppUi/VersionCompareFrontstageManager.ts

@@ -137,7 +137,7 @@ export class VersionCompareFrontstageManager {
             viewports[1].applyViewState(this._targetViewportState);
             await this._onPropertyComparisonFrontstageOpened();
           },
-          10000,
+          1000,
         );
       } else {
         // Stop property comparison
@@ -418,14 +418,17 @@ export class VersionCompareFrontstageManager {
       // Timeout to prevent hanging
       setTimeout(() => {
         IModelApp.viewManager.onViewOpen.removeListener(onViewOpenHandler);
-        vps.length = 0;
-        for( const vp of IModelApp.viewManager) {
-          vps.push(vp);
-        }
-        if( vps.length === numberOfViewPorts) {
-          // Call function once view ports are mounted
-          func(vps).then(resolve).catch(reject);
-          return;
+        // try to repopulate vps in case viewports were opened before we added the listener
+        if (vps.length !== numberOfViewPorts) {
+          vps.length = 0;
+          for (const vp of IModelApp.viewManager) {
+            vps.push(vp);
+          }
+          if (vps.length === numberOfViewPorts) {
+            // Call function once view ports are mounted
+            func(vps).then(resolve).catch(reject);
+            return;
+          }
         }
         reject(new Error(`Timeout: Expected ${numberOfViewPorts} viewports to mount within ${timeoutMs}ms`));
       }, timeoutMs);