Skip to content

Commit cc58e88

Browse files
authored
🐛Bug Fixes And List Virtualization (#253)
The named version selector now has a virtualized list of entries. This prevents massive upfront loading. Pr also fixes the following issues : - #252 - #251 - iTwin/changed-elements#251
1 parent 6074097 commit cc58e88

7 files changed

Lines changed: 749 additions & 390 deletions

File tree

.changeset/crazy-singers-hope.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
"@itwin/changed-elements-react": minor
3+
---
4+
5+
_Frontend Enhancements:_
6+
7+
1. Change named version list to be a infinite list, so we do not spam the UI with quires for constructing Named Versions
8+
9+
_Frontend Bug Fixes:_
10+
11+
1. Fixed active version header not clearing once a comparison is complete
12+
2. Disabled process result buttons when a comparison is currently being run

packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.scss

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@
111111

112112
display: grid;
113113
grid: 1fr / minmax(min-content, 1fr) minmax(min-content, auto) minmax(min-content, auto);
114-
column-gap: var(--iui-size-m);
114+
height: 100%;
115+
width: 100%;
115116

116117
> * {
117118
padding-inline: var(--_cer_v1_container-margin-internal);
@@ -164,5 +165,15 @@
164165
._cer_v1_not-processed {
165166
color: var(--iui-color-border);
166167
}
168+
169+
._cer_v1_version-content {
170+
flex: 1;
171+
min-width: 0;
172+
}
173+
174+
._cer_v1_version-details {
175+
display: grid;
176+
gap: 1px;
177+
}
167178
}
168179
}

0 commit comments

Comments
 (0)