Fixed error in the backend, and cleaned up non typesafe code in frontend

Author: CalebGerman

packages/test-app-backend/src/ChangedInstancesProcessor.ts

@@ -81,7 +81,7 @@ export class ChangedInstancesProcessor {
     changesetFileProps: Partial<ChangesetFileProps>[],
     db: IModelDb,
   ): Promise<ChangedECInstance[]> {
-    const ecChangeUnifier = new PartialECChangeUnifier();
+    const ecChangeUnifier = new PartialECChangeUnifier(db);
 
     const changesetFilePaths = changesetFileProps
       .filter((csFile) => csFile.pathname !== undefined)

packages/test-app-backend/src/main.ts

@@ -4,7 +4,7 @@
 *--------------------------------------------------------------------------------------------*/
 import { IModelHost } from "@itwin/core-backend";
 import { Logger, LogLevel } from "@itwin/core-bentley";
-import { BentleyCloudRpcManager, HttpServerRequest, HttpServerResponse, IModelReadRpcInterface, IModelTileRpcInterface, RpcManager } from "@itwin/core-common";
+import { BentleyCloudRpcManager, IModelReadRpcInterface, IModelTileRpcInterface, RpcManager } from "@itwin/core-common";
 import { ECSchemaRpcInterface } from "@itwin/ecschema-rpcinterface-common";
 import { ECSchemaRpcImpl } from "@itwin/ecschema-rpcinterface-impl";
 import { IModelJsExpressServer } from "@itwin/express-server";
@@ -14,7 +14,6 @@ import { AzureClientStorage, BlockBlobClientWrapperFactory } from "@itwin/object
 import { Presentation } from "@itwin/presentation-backend";
 import { PresentationRpcInterface } from "@itwin/presentation-common";
 import { config } from "dotenv-flow";
-import express from "express";
 import { ChangesRpcImpl } from "./RPC/ChangesRpcImpl";
 import { ChangesRpcInterface } from "./RPC/ChangesRpcInterface";
 
@@ -43,12 +42,8 @@ void (async () => {
     { info: { title: "test-app-backend", version: "v1.0" } },
     [IModelReadRpcInterface, IModelTileRpcInterface, PresentationRpcInterface, ChangesRpcInterface, ECSchemaRpcInterface],
   );
-  const app = express();
+
   const server = new IModelJsExpressServer(rpcConfig.protocol);
   await server.initialize(port);
   console.log(`Backend (PID ${process.pid}) is listening on port ${port}.`);
-
-  app.post("*", async (request: HttpServerRequest, response: HttpServerResponse) => {
-    await rpcConfig.protocol.handleOperationPostRequest(request, response);
-  });
 })();

packages/test-app-frontend/src/App/ITwinJsApp/AppUi/PropertyComparisonViewport.tsx

@@ -11,6 +11,12 @@ import React from "react";
 import { getSchemaContext } from "./presentation/SchemaContextProvider";
 import { getUnifiedSelectionStorage } from "./presentation/SelectionStorage";
 
+declare global {
+  interface Window { // extend the Window interface, via interface merging. https://www.typescriptlang.org/docs/handbook/declaration-merging.html
+    viewport?: ScreenViewport;
+  }
+}
+
 export interface PropertyComparisonViewportContentProps {
   iModelConnection: IModelConnection;
   getViewState: () => ViewStateProp | undefined;
@@ -58,8 +64,7 @@ export function PropertyComparisonViewportContent(props: PropertyComparisonViewp
       viewportRef={(v: ScreenViewport) => {
         // for convenience, if window defined bind viewport to window
         if (undefined !== window) {
-          // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unnecessary-type-assertion
-          (window as any).viewport = v;
+          window.viewport = v;
         }
       } } />
   );