Added optional string-specific maximum stops

icalvo · icalvo · commit 363959b7d08d · 2025-08-25T20:21:36.000+02:00
diff --git a/packages/string-fingerings/fingerings.ts b/packages/string-fingerings/fingerings.ts
@@ -83,7 +83,7 @@ function* stopsForString<TString extends InstrumentString>(
     return
   }
 
-  if (stopIndex > instrument.stops) {
+  if (stopIndex > (instrumentString.stops ?? instrument.stops)) {
     console.debug(`${noteName(noteNumber)} is too high to stop for ${instrumentString.name} string`)
   }
   else {
diff --git a/packages/string-fingerings/types.ts b/packages/string-fingerings/types.ts
@@ -22,6 +22,8 @@ export interface InstrumentString {
     openNote: number
     /** Additional open strings, as a MIDI number (for low range extensions) */
     additionalOpenNotes?: number[]
+    /** Maximum number of semitones that can be stopped over the open string */
+    stops?: number
 }
 
 /** Represent a string instrument */

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ function* stopsForString<TString extends InstrumentString>(`
`83`	`83`	`return`
`84`	`84`	`}`
`85`	`85`
`86`		`- if (stopIndex > instrument.stops) {`
	`86`	`+ if (stopIndex > (instrumentString.stops ?? instrument.stops)) {`
`87`	`87`	console.debug(`${noteName(noteNumber)} is too high to stop for ${instrumentString.name} string`)
`88`	`88`	`}`
`89`	`89`	`else {`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@ export interface InstrumentString {`
`22`	`22`	`openNote: number`
`23`	`23`	`/** Additional open strings, as a MIDI number (for low range extensions) */`
`24`	`24`	`additionalOpenNotes?: number[]`
	`25`	`+ /** Maximum number of semitones that can be stopped over the open string */`
	`26`	`+ stops?: number`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`/** Represent a string instrument */`